Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linkouts-v1.2.0 release #619

Merged
merged 1 commit into from
Mar 26, 2024
Merged

linkouts-v1.2.0 release #619

merged 1 commit into from
Mar 26, 2024

Conversation

adf-ncgr
Copy link
Contributor

updated dependencies, versioning

@adf-ncgr adf-ncgr requested a review from alancleary March 26, 2024 17:57
@adf-ncgr
Copy link
Contributor Author

@alancleary I put a checklist into #618, if it looks like a reasonable first pass I will convert it to a template for the repo for future use.

Copy link
Collaborator

@alancleary alancleary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes look good, although I haven't actually confirmed that it runs!

Regarding the release checklist, I would mention that pip-compile should be used and that dependabot definitely should not be used. It should also include making sure the Dockerfile image is using the most recent (LTS?) image, and mention that a test build should be done before tagging a release when the image is updated.

Thanks for taking care of the checklist!

@adf-ncgr adf-ncgr merged commit 4141f4e into main Mar 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants