Expose calcVcsState publicly for external usage
#165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #165 +/- ##
=======================================
Coverage 97.56% 97.56%
=======================================
Files 3 3
Lines 41 41
Branches 6 6
=======================================
Hits 40 40
Misses 1 1 ☔ View full report in Codecov by Sentry. |
|
Thanks for merging @lefou. Could you help me cut a tag? I'd like to begin using this in the Mill codebase once the linked PR lands |
|
There should be a automatic snapshot release published. I also started the release process for |
lihaoyi
added a commit
to com-lihaoyi/mill
that referenced
this pull request
Dec 12, 2024
Not enough to turn on selective execution in Mill's CI yet, but it's steps in that direction. * Make `BuildInfo#resources` a cached task, which is more correct (since it doesn't add any source files) and seems to remove some noise in changed `inputTaskHashes` * Fix handling of `defaultCommandName` in `selective.resolve` and add a unit test * Nicely format `mill-selective-execution.json` for easy debugging * Bump mill-vcs-version to pull in lefou/mill-vcs-version#165, so we can stabilize `build.millVersion`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary in order to make it conditionally used (e.g. only enabled based on an environment variable), so Mill's own code can take advantage of com-lihaoyi/mill#4091
As an
Task.Input, it always is present in the task graph even when the value is ignored due to anifconditional, meaning it always triggers downstream tasks and tests during selective execution. Whereas as a helper method I can guard against its usage in anifstatement (e.g. checking asys.envvariable), and if it isn't used it never ends up in the build graph at all