Dont modify redis read only lua tables #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
For the record, that change in Redis Lua engine also exists in Redis 6.2.7 (not only 7.0.0) |
|
Ok thanks! Yeah, that makes sense. I'll review properly shortly. |
Closed
|
Merged, and a new rock published to luarocks: https://luarocks.org/modules/pintsized/lua-resty-qless/0.12-0 Really sorry for the delay! |
pedropb
added a commit
to Shopify/qless
that referenced
this pull request
Mar 1, 2023
More context: - [qless fix](ledgetech/lua-resty-qless#14) - [redis 6.2.7 breaking change](redis/redis#10651) I did not regenerate the files from qless-core using the `make` instructions from the README.md because the commit we have been using [^1] dates back to Aug 2017, and the same fix has not been applied to seomoz/qless-core yet. See [^2] [1]: seomoz/qless-core@36199bf [2]: seomoz/qless-core#90
pedropb
added a commit
to Shopify/qless
that referenced
this pull request
Mar 1, 2023
More context: - [qless fix](ledgetech/lua-resty-qless#14) - [redis 6.2.7 breaking change](redis/redis#10651) I did not regenerate the files from qless-core using the `make` instructions from the README.md because the commit we have been using [^1] dates back to Aug 2017, and the same fix has not been applied to seomoz/qless-core yet. See [^2] [^1]: seomoz/qless-core@36199bf [^2]: seomoz/qless-core#90
pedropb
added a commit
to Shopify/qless
that referenced
this pull request
Mar 1, 2023
More context: - [qless fix](ledgetech/lua-resty-qless#14) - [redis 6.2.7 breaking change](redis/redis#10651) I did not regenerate the files from qless-core using the `make` instructions from the README.md because the commit we have been using [^1] dates back to Aug 2017, and the same fix has not been applied to seomoz/qless-core yet. See [^2] [^1]: seomoz/qless-core@36199bf [^2]: seomoz/qless-core#90
pedropb
added a commit
to Shopify/qless
that referenced
this pull request
Mar 1, 2023
More context: - [qless fix](ledgetech/lua-resty-qless#14) - [redis 6.2.7 breaking change](redis/redis#10651) I did not regenerate the files from qless-core using the `make` instructions from the README.md because the commit we have been using [^1] dates back to Aug 2017, and the same fix has not been applied to seomoz/qless-core yet. See [^2] [^1]: seomoz/qless-core@36199bf [^2]: seomoz/qless-core#90
bak1an
added a commit
to libqless/qless-core
that referenced
this pull request
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that Redis after version 6.2.7 doesn't allow us to modify global lua tables.
Probably added here: redis/redis#10651
The following error happens:
The line 27 is changing the table "table".
However it was required to make the function local to make the error stop.
It seems that this won't break for previous of Redis.
A new tag at luarocks would be appreciated, so Dockerfiles can run properly again.
https://luarocks.org/modules/pintsized/lua-resty-qless
Thanks!