Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inherit modal does not appear when sorting items in a folder with metadata #4849

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

bjester
Copy link
Member

@bjester bjester commented Dec 3, 2024

Summary

  • The inherit logic was not differentiating drag and drop operations that are relative moves among siblings versus operations that are changing the parent

References

Fixes #4839

Reviewer guidance

  1. Open a channel
  2. Add a new folder to the channel root
  3. Open the folder
  4. Add multiple resources into the new folder
  5. Edit the folder and set metadata via the legacy edit modal
  6. Observe an unresolved issue where the user is not notified whether the resources should inherit the new metadata
  7. Drag a resource to change its position in the folder
  8. Observe the inherit modal does not appear
  9. Navigate to the channel root
  10. Add a new file
  11. Drag the file to the tree view on the left side to drop the file resource into the folder
  12. Observe the inherit modal does appear, as it should

Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All code changes make sense - just need to manually test.

Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All manual testing steps worked as described.

@rtibbles rtibbles merged commit 161a0b4 into learningequality:hotfixes Dec 4, 2024
13 checks passed
@pcenov
Copy link
Member

pcenov commented Dec 4, 2024

No issues observed while regression testing - thanks @bjester!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants