Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow user to set prerequisite from garbage tree on new content #1173

Merged
merged 1 commit into from
Jan 17, 2019

Conversation

jayoshih
Copy link
Contributor

@jayoshih jayoshih commented Jan 12, 2019

Description

This will fix the bug where a user could select a prerequisite from the garbage tree on new content

Issue Addressed (if applicable)

#1018

Steps to Test

  • Create a new exercise
  • Without saving, open the prerequisites tab
  • Click the +ADD button

Implementation Notes (optional)

Does this introduce any tech-debt items?

In the future, I would like to move this to vue so we can use the state more effectively instead of passing variables between views

Checklist

  • Is the code clean and well-commented?
  • Have the changes been added to the CHANGELOG?

@jayoshih jayoshih merged commit d856880 into learningequality:develop Jan 17, 2019
@jayoshih jayoshih deleted the prereq-fix branch March 9, 2020 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants