Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When you leave the Preview tab, video keeps playing #728

Closed
kollivier opened this issue Jun 20, 2018 · 2 comments
Closed

When you leave the Preview tab, video keeps playing #728

kollivier opened this issue Jun 20, 2018 · 2 comments
Labels

Comments

@kollivier
Copy link
Contributor

Summary

If you select Preview on a content node and begin playing a video, then switch back to the Details tab, the video continues to play in the background. (You can hear the audio.)

Category

BUG

Usage Details

  • Browser: Chrome 67.0, OS X High Sierra
  • Channel: UbongoKids

How to reproduce

  1. Select Preview tab and play video on content node with video
  2. Switch to Details tab
  3. There is no step 3 :)

Real-life consequences (anything community should be aware of, for instance how it affects end users)

Not a major issue, but people won't expect it and will be surprised when it happens. Just filing a ticket to make sure this stays on the radar. :)

@jayoshih
Copy link
Contributor

@DXCanas Any chance you could add this into your renderers work?

@DXCanas
Copy link
Member

DXCanas commented Jun 22, 2018

The refactor of the edit/upload modal would handle this nicely, but I don't think it's in the scope of the current PR.

For this pass... I can think of a couple janky workarounds. If it's important, I can use one of them? Though I'd probably have to shower after submitting the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants