Refactors UserAuth and ProfileEdit pages not to use Corebase #9809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
nucleogenesis
requested changes
Nov 8, 2022
There was a problem hiding this comment.
I've added a non-blocking set of a few thoughts about the overall code organization; I'm maybe just overthinking it 😄
This looks great! Thank you for the comments throughout and for the new aria attr for the snackbars! With a few minor tweaks on that and a formatting issue this should be good to go!
kolibri/plugins/user_profile/assets/src/views/ProfileEditPage.vue
Outdated
Show resolved
Hide resolved
rtibbles
reviewed
Nov 10, 2022
packages/kolibri-common/index.js
Outdated
| @@ -0,0 +1,6 @@ | |||
| 'use strict'; | |||
|
|
|||
| import AppError from '../../kolibri/core/assets/src/views/AppError'; | |||
There was a problem hiding this comment.
My thought was that we could just put the files themselves in the package, wouldn't even need the index.js then, as could just import kolibri-common/components/GlobalSnackbar or somesuch.
There was a problem hiding this comment.
Ahh i see. Let me refactor this. Thanks for this clarification
nucleogenesis
approved these changes
Nov 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors UserAuthPage and ProfileEditPage to remove CoreBase usage.
References
Closes #9233
Please note that the linting build fails due to a build bug fixed by #9810
Reviewer guidance
View the following pages. Pages should function as before;
http://localhost:8000/en/auth/#/signinhttp://localhost:8000/en/profile/#/editTesting checklist
PR process
Reviewer checklist
yarnandpip)