Only show attempts column in lesson reports for practice quizzes #13046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nucleogenesis
commented
Jan 31, 2025
| anyTries() { | ||
| return this.entries.some(entry => !isUndefined(entry.statusObj.tries)); | ||
| }, | ||
| // Presumes this is a Lesson report table as quizId is only present in quiz routes |
There was a problem hiding this comment.
This got me a bit confused initially, thought this might help future-me (or someone else) because I was trying to use this.exam to get the currently-viewed resource and didn't realize the need to handle varying route params
Build Artifacts
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Modifies the condition in the ReportsLearnersTable for showing the attempts column so that it only shows if the currently viewed piece of content is a practice quiz.
Only affects the case in which the report is viewing a particular piece of content in a lesson.
References
Fixes #13011
Reviewer guidance
Edge case: When you have a practice quiz but no attempts then in this case there should be no attempts column.