fix construction of cookie using user supplied input #12808 #13029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nucleogenesis
approved these changes
Jan 30, 2025
There was a problem hiding this comment.
I manually changed my visitor ID in my cookies and navigated and the cookie was refreshed as expected.
Code changes LGTM!
Great work, thank you @KumarVivekPathak
rtibbles
requested changes
Jan 31, 2025
kolibri/core/auth/api.py
Outdated
| if not request.COOKIES.get("visitor_id"): | ||
| try: | ||
| existing_visitor_id = request.COOKIES.get("visitor_id") | ||
| if existing_visitor_id: |
There was a problem hiding this comment.
One small tweak - no need to add this if/else here - if you pass None to the UUID constructor it will also throw a TypeError so we can handle all cases where the uuid is not a valid v4 UUID in the except block.
There was a problem hiding this comment.
yes I got that I'll change it.
Build Artifacts
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses the code scanning alert in issue #12808 by ensuring that the
visitor_idcookie value is validated before use.The validation ensures:
visitor_idcookie is a valid hex UUID by attempting to parse it withUUID(visitor_id, version=4).visitor_idis generated usinguuid4().hex.visitor_idis then set in the response.