Small tweaks to simplify publishing packages. #13009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Separate out kolibri package build and kolibri-tools. Update versions for browserslist-config-kolibri and kolibri-tools.
Build Artifacts
|
marcellamaki
approved these changes
Jan 16, 2025
There was a problem hiding this comment.
- Are version updates correlated? Yes, and it seems like there are no additional places where these needs to be updated (per conversation with Richard)
- Can you run npm pack inside the kolibri-tools directory and it properly includes the language_info.json in the tar file? Yes
- Does the linting rule for rebuilding the kolibri package still work as expected? Seems so
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
References
Needed for publishing of latest kolibri-tools
Reviewer guidance
Are version updates correlated?
Can you run
npm packinside thekolibri-toolsdirectory and it properly includes the language_info.json in the tar file?Does the linting rule for rebuilding the kolibri package still work as expected?