Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move language object sorting and comparison utilities into core i18n module #12602

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

rtibbles
Copy link
Member

Summary

  • Consolidates language related utilities in the i18n module

References

Fixes #12601

Reviewer guidance

Linting should still pass.


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@github-actions github-actions bot added APP: Device Re: Device App (content import/export, facility-syncing, user permissions, etc.) DEV: frontend labels Aug 26, 2024
@nucleogenesis nucleogenesis self-assigned this Aug 26, 2024
@nucleogenesis nucleogenesis self-requested a review August 26, 2024 16:19
Copy link
Member

@nucleogenesis nucleogenesis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM

@rtibbles rtibbles merged commit 590a5e7 into learningequality:develop Aug 26, 2024
34 checks passed
@rtibbles rtibbles deleted the languages_sorted branch August 26, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Device Re: Device App (content import/export, facility-syncing, user permissions, etc.) DEV: frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move sortLanguages util into the i18n module
2 participants