-
Notifications
You must be signed in to change notification settings - Fork 739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install KDS patch and configure dependabot to run on Wednesday #11918
Conversation
Build Artifacts
|
yarn.lock
Outdated
@@ -2346,6 +2346,15 @@ aphrodite@1.1.0: | |||
asap "^2.0.3" | |||
inline-style-prefixer "^2.0.0" | |||
|
|||
"aphrodite@git+https://github.com/learningequality/aphrodite.git": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand exactly why this appeared here now but my theory is that it should have appeared when I installed v3.0.0 but it didn't because I didn't properly update KDS package.json version at that time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to only happen where I've seen you upgrade packages, specifically - a similar line was recently removed by a dependabot upgrade https://github.com/learningequality/kolibri/pull/11907/files#diff-51e4f558fae534656963876761c95b83b6ef5da5103c4adef6768219ed76c2deL2349
and I think @bjester saw something similar when doing KDS upgrades on Studio as well.
I don't quite know why this is happening, but as it seems to be in parallel with the aphrodite git reference below, it doesn't seem terribly helpful.
053c3dc
to
b92e679
Compare
Summary
v3.0.0
tov3.0.1
(KDS release notes, no breaking changes)Testing checklist
PR process
Reviewer checklist
yarn
andpip
)