Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install KDS patch and configure dependabot to run on Wednesday #11918

Merged
merged 2 commits into from
Feb 27, 2024

Conversation

MisRob
Copy link
Member

@MisRob MisRob commented Feb 23, 2024

Summary

  • Updates KDS version from v3.0.0 to v3.0.1 (KDS release notes, no breaking changes)
  • Pins KDS dependency to exact version
  • Configure dependabot to run on Wednesday to sync its timing with KDS releases planned for Tuesdays

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@MisRob MisRob requested a review from rtibbles February 23, 2024 09:23
@MisRob MisRob added the TODO: needs review Waiting for review label Feb 23, 2024
@MisRob MisRob changed the title Configure dependabot to run on Wednesday Install KDS patch and configure dependabot to run on Wednesday Feb 23, 2024
yarn.lock Outdated
@@ -2346,6 +2346,15 @@ aphrodite@1.1.0:
asap "^2.0.3"
inline-style-prefixer "^2.0.0"

"aphrodite@git+https://github.com/learningequality/aphrodite.git":
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand exactly why this appeared here now but my theory is that it should have appeared when I installed v3.0.0 but it didn't because I didn't properly update KDS package.json version at that time.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to only happen where I've seen you upgrade packages, specifically - a similar line was recently removed by a dependabot upgrade https://github.com/learningequality/kolibri/pull/11907/files#diff-51e4f558fae534656963876761c95b83b6ef5da5103c4adef6768219ed76c2deL2349

and I think @bjester saw something similar when doing KDS upgrades on Studio as well.

I don't quite know why this is happening, but as it seems to be in parallel with the aphrodite git reference below, it doesn't seem terribly helpful.

@rtibbles rtibbles self-assigned this Feb 27, 2024
@rtibbles rtibbles merged commit dd6a650 into learningequality:develop Feb 27, 2024
31 checks passed
@MisRob MisRob deleted the dependabot-config branch February 29, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants