Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix card widths on ultra wide screen #11665

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Fix card widths on ultra wide screen #11665

merged 1 commit into from
Dec 21, 2023

Conversation

iskipu
Copy link
Contributor

@iskipu iskipu commented Dec 21, 2023 •
edited
Loading

This PR is a fix to #11653

This fix is made assuming that the explorer button/text above should also be displayed within the max width of 1700px.
image

This PR only fixes Library page, because Topic/Channel View & Explore Libraries main view are already behaving as expected.

Before:
image
After:
image

@github-actions github-actions bot added APP: Device Re: Device App (content import/export, facility-syncing, user permissions, etc.) APP: Learn Re: Learn App (content, quizzes, lessons, etc.) DEV: frontend SIZE: very small labels Dec 21, 2023
@iskipu iskipu marked this pull request as draft December 21, 2023 18:25
@iskipu iskipu marked this pull request as ready for review December 21, 2023 18:26
@iskipu iskipu marked this pull request as draft December 21, 2023 18:26
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 21, 2023 •
edited
Loading

Build Artifacts

Asset type Download link
PEX file kolibri-0.16.0b10.dev0_git.44.g3039ba4d.pex
Windows Installer (EXE) kolibri-0.16.0b10.dev0+git.44.g3039ba4d-unsigned.exe
Debian Package kolibri_0.16.0b10.dev0+git.44.g3039ba4d-0ubuntu1_all.deb
Mac Installer (DMG) kolibri-0.16.0b10.dev0+git.44.g3039ba4d-0.3.0.dmg
Android Package (APK) kolibri-0.16.0b10.dev0+git.44.g3039ba4d-0.1.0-debug.apk
TAR file kolibri-0.16.0b10.dev0+git.44.g3039ba4d.tar.gz
WHL file kolibri-0.16.0b10.dev0+git.44.g3039ba4d-py2.py3-none-any.whl

@iskipu iskipu marked this pull request as ready for review December 21, 2023 19:31
@nucleogenesis nucleogenesis mentioned this pull request Dec 21, 2023
Closed
9 tasks
nucleogenesis
nucleogenesis approved these changes Dec 21, 2023
View reviewed changes
Copy link
Member

@nucleogenesis nucleogenesis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This addresses the issue perfectly, thank you @iskipu - I confirmed that the fix works as expected and have updated the description on #11653 noting that the Library page has been addressed there.

@nucleogenesis nucleogenesis merged commit a84a63a into learningequality:release-v0.16.x Dec 21, 2023
33 checks passed
@iskipu
Copy link
Contributor Author

iskipu commented Dec 22, 2023 •
edited
Loading

@nucleogenesis

this PR also fixes the Explore page mentioned in #11653
(as both the explore page and library page uses the same div)

Explore page:

image

And the Topic/Channel View mentioned in #11653 works as expected even before this PR (so i am not sure why this was mentioned in the issue)

Topic/Channel View:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nucleogenesis nucleogenesis nucleogenesis approved these changes

Assignees
No one assigned
Labels
APP: Device Re: Device App (content import/export, facility-syncing, user permissions, etc.) APP: Learn Re: Learn App (content, quizzes, lessons, etc.) DEV: frontend SIZE: very small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iskipu @nucleogenesis