Move core notifications handling into NotificationsRoot component

[rtibbles]

Currently all the admin notifications are handled through the core vuex state, but these are only accessed and used in the NotificationsRoot component and its child component UpdateNotifications.

• notifications state should instead be set as a data property on the NotificationsRoot component.
• The two actions should be moved into methods of the NotificationsRoot component, and refactored to directly alter the notifications property, rather than use Vuex mutations
• getNotifications should now be called in the created hook of the NotificationsRoot component, and references to the action in kolibri_app.js and its associated spec file should be removed
• the notifications state key should be deleted along with any associated Vuex mutations

[iamshobhraj]

@rtibbles can you please assign me this issue.

[rtibbles]

Yes, assigned! Feel free to ask any follow up questions here!

[iamshobhraj]

Yes, assigned! Feel free to ask any follow up questions here!

What two actions are to be moved as methods in NotificationRoot component. I could only find one action from the given link.

[MisRob]

Hi @iamshobhraj. From function names I would assume the other one could perhaps be saveDismissedNotification? But basically the idea here is that anything notification related that is used from the NotificationRoot needs to be in this component rather than in the global Vuex state. So even though there's useful tasks in the issue as pointers, I'd still recommend you to examine how it works right now and simply make sure all that is used solely by the NotificationRoot is placed in it.

[MisRob]

@iamshobhraj Perhaps you've already done that, so just a general recommendation - always best to preview that logic before/after on the dev server. Then you will also get a mental picture of how the user experience looks like as well as what's going on under the hood, and can use it for verification that it still works as expected after the refactor. Thanks :)!

[nucleogenesis]

Closed by #12644