Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of the assessmentmetadata state mapper #11724

Closed
3 tasks done
Tracked by #5488
rtibbles opened this issue Jan 12, 2024 · 10 comments
Closed
3 tasks done
Tracked by #5488

Remove use of the assessmentmetadata state mapper #11724

rtibbles opened this issue Jan 12, 2024 · 10 comments
Assignees
Labels
DEV: frontend help wanted Open source contributors welcome

Comments

@rtibbles
Copy link
Member

rtibbles commented Jan 12, 2024

The AssessmentMetadataState mapper was introduced when the ContentNode API returned a singleton array of assessmentmetadata. It now returns a null value or a single object.

Unfortunately, there are several places where this is still used, rather than directly reading from the expected return shape of the API endpoint.

Acceptance criteria:

Preview Give feedback
@a6ar55
Copy link
Contributor

a6ar55 commented Jan 18, 2024

I would like to work on this

@AlexVelezLl
Copy link
Member

Hi @a6ar55! Sure! I will assign this issue to you 👐.

@nick2432
Copy link
Contributor

nick2432 commented Feb 3, 2024

The current assignee is not active; can i work on this task?

@MisRob
Copy link
Member

MisRob commented Feb 5, 2024

Hi @nick2432, thanks for volunteering. Let's wait a day or two for @a6ar55 to confirm whether they're working on it or no. Then we can possibly re-assign.

@a6ar55
Copy link
Contributor

a6ar55 commented Feb 6, 2024

Hi @MisRob , Unfortunately, I am unable to work on this issue at the moment. Therefore, please feel free to reassign the task to @nick2432.

@MisRob
Copy link
Member

MisRob commented Feb 6, 2024

Thanks for letting us know, @a6ar55. I am re-assigning to @nick2432.

@MisRob MisRob assigned nick2432 and unassigned a6ar55 Feb 6, 2024
@nick2432 nick2432 removed their assignment Feb 16, 2024
@AymanHammadi
Copy link

I'd like to work on this issue. Could you please assign it to me?

Also I have a question about mastery_model values: After the removal of the assessmentMetaDataState mapper, should we assume these values will always be in snake_case format? Currently, this mapper ensures snake_case. I just want to make sure I understand it correctly.

@rtibbles
Copy link
Member Author

rtibbles commented Mar 5, 2024

Yes, the assessment metadata will now be accessed in the same way as it is returned from the API for resource metadata. The JSDoc types for this can be found here: https://github.com/learningequality/kolibri/blob/develop/kolibri/core/assets/src/api-resources/contentNode.js#L18 (see below in the same file for how to access this from the ContentNode metadata).

@rtibbles
Copy link
Member Author

rtibbles commented Mar 5, 2024

Assigned!

@rtibbles
Copy link
Member Author

rtibbles commented Mar 8, 2024

Fixed in #11940

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV: frontend help wanted Open source contributors welcome
Projects
None yet
Development

No branches or pull requests

6 participants