-
Notifications
You must be signed in to change notification settings - Fork 745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove use of the assessmentmetadata state mapper #11724
Comments
I would like to work on this |
Hi @a6ar55! Sure! I will assign this issue to you 👐. |
The current assignee is not active; can i work on this task? |
I'd like to work on this issue. Could you please assign it to me? Also I have a question about mastery_model values: After the removal of the assessmentMetaDataState mapper, should we assume these values will always be in snake_case format? Currently, this mapper ensures snake_case. I just want to make sure I understand it correctly. |
Yes, the assessment metadata will now be accessed in the same way as it is returned from the API for resource metadata. The JSDoc types for this can be found here: https://github.com/learningequality/kolibri/blob/develop/kolibri/core/assets/src/api-resources/contentNode.js#L18 (see below in the same file for how to access this from the ContentNode metadata). |
Assigned! |
Fixed in #11940 |
The AssessmentMetadataState mapper was introduced when the ContentNode API returned a singleton array of assessmentmetadata. It now returns a null value or a single object.
Unfortunately, there are several places where this is still used, rather than directly reading from the expected return shape of the API endpoint.
Acceptance criteria:
The text was updated successfully, but these errors were encountered: