Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Margins to Empty Table Message for Consistent Spacing #887

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

karankoder
Copy link
Contributor

Description

This PR resolves the issue of inconsistent margins when an empty table message is displayed. Previously, the empty message lacked the margin-top and margin-bottom spacing that is present when the table contains data, resulting in a visual inconsistency.

Issue addressed

Closes #881

Addresses #881

Before/after screenshots

Before Image
After Image

Changelog

  • Description: Added margin-top: 16px and margin-bottom: 16px to the empty table message to ensure consistent spacing with the table header and data rows.
  • Products impact: bugfix
  • Addresses: - [KTable]: Add margin to empty text #881
  • Components: KTable
  • Breaking: no
  • Impacts a11y: no
  • Guidance:

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical and brittle code paths are covered by unit tests
  • The change is described in the changelog section above

Reviewer guidance

  • Is the code clean and well-commented?
  • Are there tests for this change?
  • Are all UI components LTR and RTL compliant (if applicable)?
  • Add other things to check for here

Comments

@AlexVelezLl
Copy link
Member

Thanks @karankoder! This looks good. Although if you see the files changed you will see that there are lots of changes that arent actually needed. The lint action is failing because of that. Please run yarn lint-fix to fix these linting issues, and make sure that just the needed changes are in the PR :).

@karankoder
Copy link
Contributor Author

I've run yarn lint-fix to resolve the linting issues and reverted the unnecessary changes. The PR now contains only the required updates.

Could you please assign me #883? I had mentioned this earlier as well.

Copy link
Member

@AlexVelezLl AlexVelezLl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @karankoder! This looks good to me! Code changes make sense, and manual QA confirms the fix. Thanks!

@AlexVelezLl
Copy link
Member

Oh apologies, I forgot about #883, its usually a little bit hard to track conversations if they dont happen in the same issue 😅. Its already assigned now, but If you are interested in picking more issues up, I would suggest you to pick #210 :), if you are interested, you can comment on that issue, and ask to be assigned :)

@AlexVelezLl AlexVelezLl merged commit e0e2cd8 into learningequality:develop Jan 14, 2025
9 checks passed
learning-equality-bot bot pushed a commit that referenced this pull request Jan 14, 2025
@karankoder
Copy link
Contributor Author

No worries at all! 😊 Thanks for letting me know. I'll check out #210 right away and leave a comment to request the assignment. Appreciate the suggestion! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[KTable]: Add margin to empty text
2 participants