Migration to Python3 #3616
Merged
Migration to Python3 #3616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
full command/config: python -m modernize --no-diffs --write --nobackups --six-unicode --enforce --fix=default --fix=libmodernize.fixes.fix_open -f classic_division -f open -f idioms -f set_literal -f ws_comma .
|
Regarding Python 3.7, its end-of-life is only a few months way (2023-06-27). |
|
Good catch, Ted. I think we want to avoid upgrading Django in this PR (the main limiting library), but we should make a separate issue to bump Django as soon as possible. Then we can bump to a current version of Python. Only potential reason I can see to do it sooner is that this tool https://docs.python.org/3.10/library/functools.html#functools.cmp_to_key buys us a lot of ground with the |
Change 'is' to '==' when used with a literal 'png' drop database test_test_django in the before_script
Since __name__ requires `str` type, also add a `str` cast in create_membership_method.
|
For the record, once the tests are fixed up and everything, you can test locally by running |
…d other minor USC fixes)
change string representation of types to be correct and use string as default so that errors will emerge when admins look at answers rather than when students/teachers submit them
…limited/ESP-Website into migration-to-python3
This was
linked to
issues
Dec 4, 2024
willgearty
approved these changes
Dec 6, 2024
|
🤩 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate the codebase to Python 3 (currently 3.7, aiming for higher once we bump Django and other packages)
Fixes #2576.