Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(period): wrong name for validator address attribute in period options #172

Merged
merged 2 commits into from
Jan 28, 2020

Conversation

troggy
Copy link
Member

@troggy troggy commented Jan 28, 2020

getPeriodByBlockHeight API returns validatorAddress, not ownerAddress:

curl --location --request POST 'https://testnet-node.leapdao.org/' \
--header 'Content-Type: application/json' \
--data-raw '{
  "method": "plasma_getPeriodByBlockHeight",
  "params": ["190000"],
  "id": 1,
  "jsonrpc": "2.0"
}'

returns

{
    "jsonrpc": "2.0",
    "id": 1,
    "result": [
        {
            "periodStart": 189984,
            "periodEnd": 190015,
            "casBitmap": "0xc000000000000000000000000000000000000000000000000000000000000000",
            "slotId": "0",
            "validatorAddress": "0xDe42468b9ba193384eA76e337BAe1676932133Cf"
        }
    ]
}

Copy link
Contributor

@TheReturnOfJan TheReturnOfJan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed on call.

@troggy troggy merged commit fcea469 into master Jan 28, 2020
@troggy troggy deleted the fix/period-data branch January 28, 2020 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants