Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(period): adapt to new getPeriodByBlockHeight API #171

Merged
merged 1 commit into from
Feb 6, 2020
Merged

feat(period): adapt to new getPeriodByBlockHeight API #171

merged 1 commit into from
Feb 6, 2020

Conversation

troggy
Copy link
Member

@troggy troggy commented Jan 28, 2020

Adapts to the changes introduced in leapdao/leap-node#403

getPeriodByBlockHeight API now returns object instead of array.

This is BREAKING CHANGE

@troggy troggy changed the title feat: adapt to new getPeriodByBlockHeight API feat(period): adapt to new getPeriodByBlockHeight API Jan 28, 2020
@troggy troggy mentioned this pull request Jan 28, 2020
Merged
@troggy troggy force-pushed the fix/new-period-data-api branch from f0e344c to 9f077f2 Compare February 4, 2020 14:46
@troggy troggy requested a review from TheReturnOfJan February 4, 2020 14:47
@codecov-io
Copy link

Codecov Report

Merging #171 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #171   +/-   ##
=======================================
  Coverage   82.98%   82.98%           
=======================================
  Files          13       13           
  Lines        1093     1093           
=======================================
  Hits          907      907           
  Misses        186      186
Impacted Files Coverage Δ
lib/helpers.js 34.93% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcea469...9f077f2. Read the comment docs.

@troggy
Copy link
Member Author

troggy commented Feb 4, 2020

release temporary in leap-core 2.0.0-preview.1

TheReturnOfJan
TheReturnOfJan approved these changes Feb 6, 2020
View reviewed changes
Copy link
Contributor

@TheReturnOfJan TheReturnOfJan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@troggy troggy merged commit b8b28ad into master Feb 6, 2020
@troggy troggy deleted the fix/new-period-data-api branch February 6, 2020 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheReturnOfJan TheReturnOfJan TheReturnOfJan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@troggy @codecov-io @TheReturnOfJan