feat(exit): emit signed exit transfer tx details before signing an exit message #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xit message. This way the client has a chance to store the transfer tx, to resume exit process later e.g. if the user rejected exit signature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way the client has a chance to store the transfer tx, to resume exit process later e.g.
if the user rejected exit signature.
fastSell*methods —rootChainis aWeb3, notExtendedWeb3fastSell*methods to return PromiEvent and emittransferevent as soon as exiting utxo is transferred to exitHandler contractfastSellhelper in two parts:fastSellandsignAndSendFastSellRequest. The latter allows to resume fast exit after the exiting utxo already spent to exitHandler contract (see Bridge UI for usage example)