Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

token voting #262

Merged
merged 7 commits into from
Dec 17, 2019
Merged

token voting #262

merged 7 commits into from
Dec 17, 2019

Conversation

johannbarbie
Copy link
Member

resolves #261

@codecov-io
Copy link

codecov-io commented Dec 13, 2019 •
edited
Loading

Codecov Report

Merging #262 into master will increase coverage by 0.45%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #262      +/-   ##
==========================================
+ Coverage   75.68%   76.14%   +0.45%     
==========================================
  Files          40       41       +1     
  Lines         946     1006      +60     
  Branches      219      236      +17     
==========================================
+ Hits          716      766      +50     
  Misses         98       98              
- Partials      132      142      +10
Impacted Files Coverage Δ
contracts/TokenGovernance.sol 83.33% <83.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc36403...5797448. Read the comment docs.

@johannbarbie johannbarbie marked this pull request as ready for review December 14, 2019 08:27
MaxStalker
MaxStalker reviewed Dec 15, 2019
View reviewed changes
test/tokenGovernance.js Outdated Show resolved Hide resolved
contracts/TokenGovernance.sol Outdated Show resolved Hide resolved
contracts/TokenGovernance.sol Outdated Show resolved Hide resolved
contracts/TokenGovernance.sol Outdated Show resolved Hide resolved
contracts/TokenGovernance.sol Outdated Show resolved Hide resolved
contracts/TokenGovernance.sol Show resolved Hide resolved
contracts/TokenGovernance.sol Outdated Show resolved Hide resolved
contracts/TokenGovernance.sol Outdated Show resolved Hide resolved
contracts/TokenGovernance.sol Show resolved Hide resolved
johannbarbie and others added 3 commits December 16, 2019 11:09
@johannbarbie @MaxStalker
Update test/tokenGovernance.js
8fb24bd 
Co-Authored-By: Maksim Daunarovich <max.daunarovich@gmail.com>
@johannbarbie
addressed review
5189d83
@johannbarbie
Merge branch 'feature/tokenVoting' of github.com:leapdao/leap-contrac…
8cd4800 
…ts into feature/tokenVoting
MaxStalker
MaxStalker approved these changes Dec 17, 2019
View reviewed changes
Copy link
Member

@MaxStalker MaxStalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, @johannbarbie ! 👍

@johannbarbie johannbarbie merged commit a5196d9 into master Dec 17, 2019
@johannbarbie johannbarbie deleted the feature/tokenVoting branch December 17, 2019 15:36
@troggy troggy mentioned this pull request Feb 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxStalker MaxStalker MaxStalker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create Token Governance Smart Contract
3 participants
@johannbarbie @codecov-io @MaxStalker