Skip to content
This repository has been archived by the owner on Oct 21, 2024. It is now read-only.

fix(04,08,11,13): fix chapters to reflect changes in Lean. Closes #196. #197

Merged
merged 2 commits into from
May 20, 2016

Conversation

avigad
Copy link
Contributor

@avigad avigad commented May 19, 2016

This fix adapts to recent changes in Lean, notably the removal of by+, assert, etc.

The tutorial needs an overhaul, and I have a list of corrections Nathan Carter that is now almost a year old. But at this point it seems to make sense to wait for Lean 3, and revise the tutorial for the new system.

@leodemoura I am not sure what to say about the semicolon in tactic mode. You removed backtracking, right? So is there any difference between by foo; bar and begin foo, bar end?

#
# ** Making Auxiliary Facts Visible
# :PROPERTIES:
# :CUSTOM_ID: Making_Auxiliary_Facts_Visible
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@avigad, Making_Auxiliary_Facts_Visible is commented out here, but still used in Chapter 12. Could you take care of it?

@avigad
Copy link
Contributor Author

avigad commented May 20, 2016

@soonhokong My bad. I just added that fix. Now "make test" and "make" both succeed, so hopefully we're good.

@soonhokong
Copy link
Contributor

@avigad, thanks! I'll close this issue and process other PRs tonight.

@soonhokong soonhokong merged commit 0ebc199 into leanprover:master May 20, 2016
@leodemoura
Copy link
Member

@leodemoura I am not sure what to say about the semicolon in tactic mode. You removed backtracking, right? So is there any difference between by foo; bar and begin foo, bar end?

The master branch still implements backtracking. So, this part is fine for now.
After the refactoring, and lean3 becomes the main branch, we will need a major change in the tactic section.
We will use the monadic do notation (like Haskell) for writing tactic scripts.
I'm planning to keep the begin - end blocks for "interactive use". The main difference will be implicit quotation, and ,-notation for entering a sequence of tactics.

@avigad
Copy link
Contributor Author

avigad commented May 24, 2016

I'm looking forward to the new tactic language.

Something caused at least one of these two examples in the tutorial to break (I think it was the second one): 0fdeb02#diff-77be5851357653823680ddcaf7d93760R258

So I commented out the section. I think we can do without it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants