Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI - add support for prebuilt iOS artifacts (Simulator only) #465

Merged
merged 15 commits into from
Oct 19, 2022
Merged

CLI - add support for prebuilt iOS artifacts (Simulator only) #465

merged 15 commits into from
Oct 19, 2022

Conversation

bartekpacia
Copy link
Contributor

@bartekpacia bartekpacia commented Oct 17, 2022 •
edited
Loading

This PR:

More about prebuilt artifacts:

  • the CLI will use prebuilt artifacts when running on iphonesimulator (Simulator.app)
  • the CLI will still rebuild artifacts on every test run when running on iphoneos(physical iOS devices), because of problems with code signing that will be resolved in a separate PR.
  • some refactoring was done as well

@github-actions github-actions bot added automator: ios package: patrol_cli Related to the patrol_cli package labels Oct 17, 2022
@bartekpacia bartekpacia force-pushed the feature/cli_ios_artifacts branch 2 times, most recently from 204812f to 48257a2 Compare October 17, 2022 19:29
@bartekpacia bartekpacia force-pushed the feature/cli_ios_artifacts branch from 33e330d to 6280d33 Compare October 17, 2022 20:31
@bartekpacia bartekpacia force-pushed the feature/cli_ios_artifacts branch from 1c5136f to 5b8d4ed Compare October 18, 2022 13:13
@bartekpacia bartekpacia force-pushed the feature/cli_ios_artifacts branch from c2f8843 to f776dd4 Compare October 18, 2022 17:11
@bartekpacia bartekpacia force-pushed the feature/cli_ios_artifacts branch 4 times, most recently from 9c7363a to 1c6955d Compare October 18, 2022 17:53
@bartekpacia bartekpacia requested a review from shilangyu October 18, 2022 17:54
@bartekpacia bartekpacia force-pushed the feature/cli_ios_artifacts branch from 1c6955d to 799cf86 Compare October 18, 2022 17:56
@bartekpacia bartekpacia force-pushed the feature/cli_ios_artifacts branch from 799cf86 to f3321f0 Compare October 18, 2022 17:59
shilangyu
shilangyu approved these changes Oct 19, 2022
View reviewed changes
packages/patrol_cli/lib/src/common/artifacts_repository.dart Outdated

const Artifact._();

/// Nmae of the file once downloaded and extracted.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo

@bartekpacia bartekpacia force-pushed the feature/cli_ios_artifacts branch from 492d782 to b5e02ef Compare October 19, 2022 07:11
@bartekpacia bartekpacia merged commit 1880ba4 into master Oct 19, 2022
@bartekpacia bartekpacia deleted the feature/cli_ios_artifacts branch October 19, 2022 07:12
@bartekpacia bartekpacia changed the title CLI - add support for prebuilt iOS artifacts CLI - add support for prebuilt iOS artifacts (Simulator only) Oct 19, 2022
bartekpacia added a commit that referenced this pull request Oct 19, 2022
@bartekpacia
CLI - add support for prebuilt iOS artifacts (#465)
60f0bee
bartekpacia added a commit that referenced this pull request Oct 19, 2022
@bartekpacia
CLI - add support for prebuilt iOS artifacts (#465)
f01d429
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilangyu shilangyu shilangyu approved these changes

Assignees
No one assigned
Labels
package: patrol_cli Related to the patrol_cli package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Automatically download artifacts on patrol update
2 participants
@bartekpacia @shilangyu