Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Control Center for enabling/disabling services on iOS #380

Merged
merged 9 commits into from
Sep 29, 2022
Merged

Use Control Center for enabling/disabling services on iOS #380

merged 9 commits into from
Sep 29, 2022

Conversation

bartekpacia
Copy link
Contributor

@bartekpacia bartekpacia commented Sep 27, 2022 •
edited
Loading

In this PR

Demo

Everything on the video is done by Patrol

RPReplay_Final1664372535.mov

@github-actions github-actions bot added the package: patrol Related to the patrol package (native automation, test bundling) label Sep 28, 2022
@bartekpacia bartekpacia marked this pull request as ready for review September 28, 2022 13:32
@bartekpacia
Copy link
Contributor Author

bartekpacia commented Sep 28, 2022 •
edited
Loading

This works like a charm except when it doesn't. We're plagued by Flutter Driver's instability.

Unhandled exception:
DriverError: Failed to fulfill RequestData due to remote error
Original error: ext.flutter.driver: (112) Service has disappeared
Original stack trace:
#0      new _OutstandingRequest (package:vm_service/src/vm_service.dart:1746:45)
#1      VmService._call (package:vm_service/src/vm_service.dart:2262:21)
#2      VmService.callServiceExtension (package:vm_service/src/vm_service.dart:2233:14)
#3      VMServiceFlutterDriver.sendCommand (package:flutter_driver/src/driver/vmservice_driver.dart:306:66)
#4      FlutterDriver.requestData (package:flutter_driver/src/driver/driver.dart:522:45)
#5      integrationDriver (package:integration_test/integration_test_driver.dart:76:42)
<asynchronous suspension>


#0      VMServiceFlutterDriver.sendCommand (package:flutter_driver/src/driver/vmservice_driver.dart:318:7)
<asynchronous suspension>
#1      FlutterDriver.requestData (package:flutter_driver/src/driver/driver.dart:522:39)
<asynchronous suspension>
#2      integrationDriver (package:integration_test/integration_test_driver.dart:76:29)
<asynchronous suspension

See also:

@bartekpacia bartekpacia force-pushed the tweak/ios_control_centre branch from f5e33da to c8971a6 Compare September 28, 2022 13:51
@bartekpacia bartekpacia changed the title Use Control Centre for enabling/disabling services on iOS Use Control Center for enabling/disabling services on iOS Sep 28, 2022
lewandowski-jan
lewandowski-jan approved these changes Sep 29, 2022
View reviewed changes
Copy link

@lewandowski-jan lewandowski-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bartekpacia bartekpacia merged commit 8f016e7 into master Sep 29, 2022
@bartekpacia bartekpacia deleted the tweak/ios_control_centre branch September 29, 2022 10:18
@bartekpacia bartekpacia mentioned this pull request Sep 30, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lewandowski-jan lewandowski-jan lewandowski-jan approved these changes

@shilangyu shilangyu Awaiting requested review from shilangyu

Assignees
No one assigned
Labels
package: patrol Related to the patrol package (native automation, test bundling)
Projects
None yet
Milestone
No milestone
2 participants
@bartekpacia @lewandowski-jan