Use protobuf and gRPC #338

bartekpacia · 2022-09-22T07:51:17Z

…iteToJsonMap()`

AutomatorServer/android/app/src/androidTest/java/pl/leancode/automatorserver/PatrolAutomator.kt

contracts.proto

packages/patrol/example/integration_test/features/wifi_test.dart

packages/patrol/example/integration_test/ios/devel_test.dart

AutomatorServer/ios/AutomatorServerUITests/PatrolAutomation.swift

gen_protobufs

Co-authored-by: Mateusz Pietras <42344554+Xezolpl@users.noreply.github.com>

changes were addressed

bartekpacia added 7 commits September 21, 2022 13:29

start writing contracts.proto

844c7a9

add gen_protobufs script

9cfbc45

successfully generate Dart contracts

51aa7d3

simplify gen_protobufs script

4fd5e65

successfully generate Swift contracts

8f9ef50

generate android contracts, but they're broken

cf0f444

fix build

d88002f

github-actions bot added the package: patrol Related to the patrol package (native automation, test bundling) label Sep 22, 2022

successfully generate Java classes

e88d473

bartekpacia force-pushed the use_protobuf branch from 3c91f56 to e88d473 Compare September 22, 2022 09:24

bartekpacia added 2 commits September 22, 2022 13:17

migrate to using JSON as a transport

054ba9c

fix Dart side sending wrong data: use toProto3Json() instead fo `wr…

fa44754

…iteToJsonMap()`

bartekpacia force-pushed the use_protobuf branch from 714aca9 to fa44754 Compare September 22, 2022 12:01

native_automator.dart: use action and body named args, fix serde

0b34f6c

bartekpacia force-pushed the use_protobuf branch from 87ae08d to 0b34f6c Compare September 22, 2022 12:24

bartekpacia added 2 commits September 22, 2022 14:45

fix getNotifications not working

b7a00e6

Android AutomatorServer: log response bodies

bcafb45

bartekpacia force-pushed the use_protobuf branch from 49360a7 to bcafb45 Compare September 22, 2022 13:29

implement app switcher on iOS

e22eb44

bartekpacia force-pushed the use_protobuf branch from dd25ced to e22eb44 Compare September 22, 2022 13:58

bartekpacia added 4 commits September 22, 2022 16:42

generate Kotlin classes

b518edc

Merge branch 'master' into use_protobuf

b8d5fc2

ignore generated Java/Kotlin classes from git diff

4939579

spelling fix

864ed50

bartekpacia force-pushed the use_protobuf branch from fb9bbd6 to 864ed50 Compare September 22, 2022 14:57

bartekpacia added 2 commits September 22, 2022 16:59

actually ignore generated Java/Kotlin classes from git diff

e464e7e

ignore generated Dart code from GitHub diff

f2f97c0

bartekpacia commented Sep 22, 2022

View reviewed changes

AutomatorServer/android/app/src/androidTest/java/pl/leancode/automatorserver/PatrolAutomator.kt Outdated Show resolved Hide resolved

bartekpacia commented Sep 22, 2022

View reviewed changes

contracts.proto Outdated Show resolved Hide resolved

format generated protobuf files

1c6619f

bartekpacia added 5 commits September 25, 2022 16:43

ios: remove Telegraph

779224e

delete unneeded patrol_drive_helper.dart

d5d616b

add error handling on Android and Dart

b3dcf2a

add readme to gen_protobufs

a9ae40a

Android: try to make ktlint ignore contracts

8891848

bartekpacia force-pushed the use_protobuf branch from 0599f1a to 8891848 Compare September 26, 2022 10:45

format generated protobuf files

be0546f

bartekpacia requested a review from lewandowski-jan September 26, 2022 11:36

bartekpacia added 6 commits September 26, 2022 13:39

hide generated swift files from git

74a1058

remove unnecessary comment

b93e9c4

define and use Empty type instead of multiple empty messages

75257ed

Dart: re-add log printing

8c57490

format generated protobuf files

d0cd899

fix patrol bootstrap

603eec9

github-actions bot added the package: patrol_cli Related to the patrol_cli package label Sep 26, 2022

Xezolpl requested changes Sep 26, 2022

View reviewed changes

packages/patrol/example/integration_test/features/wifi_test.dart Outdated Show resolved Hide resolved

packages/patrol/example/integration_test/ios/devel_test.dart Outdated Show resolved Hide resolved

Xezolpl previously requested changes Sep 26, 2022

View reviewed changes

AutomatorServer/ios/AutomatorServerUITests/PatrolAutomation.swift Outdated Show resolved Hide resolved

jakubfijalkowski reviewed Sep 26, 2022

View reviewed changes

AutomatorServer/ios/AutomatorServerUITests/PatrolAutomation.swift Outdated Show resolved Hide resolved

gen_protobufs Outdated Show resolved Hide resolved

bartekpacia and others added 2 commits September 26, 2022 19:59

Fix typo

aa78f93

Co-authored-by: Mateusz Pietras <42344554+Xezolpl@users.noreply.github.com>

fix indents and empty lines

eeca775

bartekpacia force-pushed the use_protobuf branch from 1ebd97d to eeca775 Compare September 26, 2022 18:05

bartekpacia and others added 2 commits September 26, 2022 20:08

fix typo

241c376

Co-authored-by: Mateusz Pietras <42344554+Xezolpl@users.noreply.github.com>

remove debug aid file

2cf2718

bartekpacia added 2 commits September 26, 2022 20:26

update bootstrap command

737d618

remove needless blank line

5bde91e

bartekpacia merged commit a0c16bb into master Sep 26, 2022

bartekpacia deleted the use_protobuf branch September 26, 2022 18:51

bartekpacia mentioned this pull request Sep 29, 2022

Fix getNativeWidgets() on Android #393

Merged

bartekpacia mentioned this pull request Jul 20, 2023

Stop depending on gRPC on iOS #1532

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use protobuf and gRPC #338

Use protobuf and gRPC #338

bartekpacia commented Sep 22, 2022 •

edited

Loading

Use protobuf and gRPC #338

Use protobuf and gRPC #338

Conversation

bartekpacia commented Sep 22, 2022 • edited Loading

bartekpacia commented Sep 22, 2022 •

edited

Loading