Fix/flutter 3.29 (#2530)

* Fix dispose semantics issue on Android * Update changelog * Update Flutter version to 3.29.x in Android emulator workflows * Remove reversed changes from changelog --------- Co-authored-by: piotruela <piotr.maszota@leancode.co>
leancodepl · Feb 20, 2025 · 5d1c503 · 5d1c503
1 parent c08611a
commit 5d1c503
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 13 deletions.
diff --git a/.github/workflows/test-android-emulator-webview.yaml b/.github/workflows/test-android-emulator-webview.yaml
@@ -24,7 +24,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        flutter-version: ["3.24.x"]
+        flutter-version: ["3.29.x"]
         flutter-channel: ["stable"]
 
     defaults:

diff --git a/.github/workflows/test-android-emulator.yaml b/.github/workflows/test-android-emulator.yaml
@@ -25,7 +25,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        flutter-version: ["3.24.x"]
+        flutter-version: ["3.29.x"]
         flutter-channel: ["stable"]
 
     defaults:

diff --git a/packages/patrol/CHANGELOG.md b/packages/patrol/CHANGELOG.md
@@ -1,11 +1,10 @@
 ## Unreleased
 
-- Remove adding build phases from iOS and macOS setup. (#2510)
-- Remove build phases from the example app. (#2510)
 - Bump patrol plugin iOS and macOS deployment targets to 12.0. (#2514)
 - Bump Gradle version in the example app so it's possible to build them on the
   latest JDK 23 (#2503)
 - Fix `$.native.tap()` not working with `Selector` having `instance` set. (#2501)
+- Fix not disposed semantics issue in Flutter 3.29.0 (#2530)
 
 ## 3.14.0
 

diff --git a/packages/patrol/lib/src/common.dart b/packages/patrol/lib/src/common.dart
@@ -1,5 +1,4 @@
 import 'dart:developer';
-import 'dart:io' as io;
 
 import 'package:boolean_selector/boolean_selector.dart';
 import 'package:flutter/foundation.dart';
@@ -126,14 +125,12 @@ void patrolTest(
           return;
         }
       }
-      if (!kIsWeb && io.Platform.isIOS) {
-        widgetTester.binding.platformDispatcher.onSemanticsEnabledChanged = () {
-          // This callback is empty on purpose. It's a workaround for tests
-          // failing on iOS.
-          //
-          // See https://github.com/leancodepl/patrol/issues/1474
-        };
-      }
+      widgetTester.binding.platformDispatcher.onSemanticsEnabledChanged = () {
+        // This callback is empty on purpose. It's a workaround for tests
+        // failing on iOS and (from Flutter 3.29.0) on Android.
+        //
+        // See https://github.com/leancodepl/patrol/issues/1474
+      };
       await automator.configure();
       // We don't have to call this line because automator.configure() does the same.
       // await automator2.configure();