[CORELIB-182] Fix dotnet and rider warnings, remove StyleCop leftovers

.editorconfig

@@ -208,8 +208,17 @@ dotnet_diagnostic.IDE0058.severity = none
 dotnet_diagnostic.xUnit1051.severity = none
 
 # Rider
-resharper_inconsistent_naming_highlighting=hint
-
-[test-bed/**/*.cs]
-resharper_not_null_or_required_member_is_not_initialized_highlighting = none
-resharper_class_never_instantiated_global_highlighting = none
+resharper_inconsistent_naming_highlighting = hint
+resharper_static_member_in_generic_type_highlighting = hint
+resharper_check_namespace_highlighting = hint
+resharper_variable_hides_outer_variable_highlighting = hint
+resharper_parameter_hides_member_highlighting = hint
+resharper_not_null_or_required_member_is_not_initialized_highlighting = hint
+
+resharper_convert_type_check_pattern_to_null_check_highlighting = none
+resharper_convert_type_check_to_null_check_highlighting = none
+
+[test/**]
+resharper_equal_expression_comparison_highlighting = none
+resharper_entity_framework_model_validation_unlimited_string_length_highlighting = none
+resharper_unused_auto_property_accessor_local_highlighting = none

src/CQRS/LeanCode.CQRS.AspNetCore/Registration/CQRSApiDescriptionProvider.cs

@@ -1,4 +1,5 @@
 using System.Collections.Immutable;
+using System.Diagnostics.CodeAnalysis;
 using System.Text;
 using LeanCode.Contracts;
 using LeanCode.CQRS.Execution;
@@ -212,6 +213,7 @@ private static void AddCommonResponses(ApiDescription apiDescription)
     private static CQRSBodyModelMetadata CreateModelMetadata(Type type) => new(ModelMetadataIdentity.ForType(type));
 }
 
+[SuppressMessage("ReSharper", "UnassignedGetOnlyAutoProperty")]
 internal sealed class CQRSBodyModelMetadata : ModelMetadata
 {
     public CQRSBodyModelMetadata(ModelMetadataIdentity identity)
@@ -221,7 +223,7 @@ public CQRSBodyModelMetadata(ModelMetadataIdentity identity)
         ImmutableDictionary<object, object>.Empty;
     public override string? BinderModelName { get; }
     public override Type? BinderType { get; }
-    public override BindingSource? BindingSource => BindingSource.Body;
+    public override BindingSource BindingSource => BindingSource.Body;
     public override bool ConvertEmptyStringToNull { get; }
     public override string? DataTypeName { get; }
     public override string? Description { get; }

src/CQRS/LeanCode.CQRS.AspNetCore/Registration/ServiceCollectionRegistrationExtensions.cs

@@ -22,10 +22,10 @@ public static void AddCQRSHandler(this IServiceCollection serviceCollection, CQR
     {
         serviceCollection.Add(new(obj.HandlerType, obj.HandlerType, ServiceLifetime.Scoped));
         serviceCollection.Add(
-            new(MakeHandlerInterfaceType(obj), sp => sp.GetRequiredService(obj.HandlerType), ServiceLifetime.Scoped)
+            new(MakeHandlerInterfaceType(), sp => sp.GetRequiredService(obj.HandlerType), ServiceLifetime.Scoped)
         );
 
-        Type MakeHandlerInterfaceType(CQRSObjectMetadata obj)
+        Type MakeHandlerInterfaceType()
         {
             return obj.ObjectKind switch
             {

src/CQRS/LeanCode.CQRS.Execution/IOperationHandler.cs

@@ -6,5 +6,5 @@ namespace LeanCode.CQRS.Execution;
 public interface IOperationHandler<in TOperation, TResult>
     where TOperation : IOperation<TResult>
 {
-    public Task<TResult> ExecuteAsync(HttpContext context, TOperation operation);
+    Task<TResult> ExecuteAsync(HttpContext context, TOperation operation);
 }

src/CQRS/LeanCode.CQRS.MassTransitRelay/MassTransitRegistrationConfigurationExtensions.cs

@@ -31,7 +31,7 @@ Type defaultDefinition
     )
     {
         var outer = types.Where(RegistrationMetadata.IsConsumer);
-        var inner = types.Where((Type x) => x.HasInterface(typeof(IConsumerDefinition<>)));
+        var inner = types.Where(x => x.HasInterface(typeof(IConsumerDefinition<>)));
         var enumerable =
             from c in outer
             join d in inner on c equals d.GetClosingArgument(typeof(IConsumerDefinition<>)) into dc

src/CQRS/LeanCode.CQRS.MassTransitRelay/Testing/ResettableBusActivityMonitor.cs

@@ -15,7 +15,7 @@ public sealed class ResettableBusActivityMonitor
 {
     private readonly object mutex = new object();
     private readonly AsyncManualResetEvent inactive = new(true);
-    private readonly RollingTimer timer;
+    private readonly RollingTimer rollingTimer;
 
     private volatile int consumersInFlight;
     private volatile int receiversInFlight;
@@ -27,7 +27,7 @@ public sealed class ResettableBusActivityMonitor
 
     public ResettableBusActivityMonitor(TimeSpan inactivityWaitTime)
     {
-        timer = new RollingTimer(OnTimer, inactivityWaitTime);
+        rollingTimer = new RollingTimer(OnTimer, inactivityWaitTime);
     }
 
     public static ResettableBusActivityMonitor CreateFor(IBusControl bus, TimeSpan inactivityWaitTime)
@@ -83,15 +83,15 @@ Task IPublishObserver.PublishFault<T>(PublishContext<T> context, Exception excep
         Decrement(ref publishInFlight);
 
     [System.Diagnostics.CodeAnalysis.SuppressMessage("?", "CA1063", Justification = "We want clean API.")]
-    void IDisposable.Dispose() => timer.Dispose();
+    void IDisposable.Dispose() => rollingTimer.Dispose();
 
     private Task Increment(ref int counter)
     {
         lock (mutex)
         {
             Interlocked.Increment(ref counter);
             inactive.Reset();
-            timer.Stop();
+            rollingTimer.Stop();
         }
 
         return Task.CompletedTask;
@@ -105,7 +105,7 @@ private Task Decrement(ref int counter)
 
             if (HasStabilized)
             {
-                timer.Restart();
+                rollingTimer.Restart();
             }
         }
 

src/CQRS/LeanCode.CQRS.Security/IAuthorizerResolver.cs

@@ -1,6 +1,6 @@
 namespace LeanCode.CQRS.Security;
 
-public interface IAuthorizerResolver<TAppContext>
+public interface IAuthorizerResolver
 {
     ICustomAuthorizerWrapper? FindAuthorizer(Type authorizerType, Type objectType);
 }

src/Core/LeanCode.Startup.Autofac/LeanProgram.cs

@@ -15,7 +15,7 @@ public static IHostBuilder BuildMinimalHost<TStartup>()
         return new HostBuilder()
             .UseServiceProviderFactory(new AutofacServiceProviderFactory())
             .ConfigureAppConfiguration(
-                (hostingContext, config) =>
+                (_, config) =>
                 {
                     config.AddEnvironmentVariables();
                 }

src/Core/LeanCode.Startup.MicrosoftDI/LeanProgram.cs

@@ -13,7 +13,7 @@ public static IHostBuilder BuildMinimalHost<TStartup>()
     {
         return new HostBuilder()
             .ConfigureAppConfiguration(
-                (hostingContext, config) =>
+                (_, config) =>
                 {
                     config.AddEnvironmentVariables();
                 }

src/Domain/LeanCode.DomainModels.EF/CachingEFRepository.cs

@@ -35,7 +35,7 @@ protected CachingEFRepository(TContext dbContext)
     {
         // Safety: aggregates are bound to have Id as a primary key by design.
         var primaryKey = DbContext.Model.FindEntityType(typeof(TEntity))!.FindPrimaryKey()!;
-        return ((IDbContextDependencies)DbContext).StateManager!.TryGetEntryTyped(primaryKey, id)?.Entity as TEntity;
+        return ((IDbContextDependencies)DbContext).StateManager.TryGetEntryTyped(primaryKey, id)?.Entity as TEntity;
     }
 
     [SuppressMessage(
@@ -47,7 +47,7 @@ protected CachingEFRepository(TContext dbContext)
     {
         // Safety: aggregates are bound to have Id as a primary key by design.
         var primaryKey = DbContext.Model.FindEntityType(typeof(TEntity))!.FindPrimaryKey()!;
-        return ((IDbContextDependencies)DbContext).StateManager!.TryGetEntryTyped(primaryKey, id)?.Entity as TEntity;
+        return ((IDbContextDependencies)DbContext).StateManager.TryGetEntryTyped(primaryKey, id)?.Entity as TEntity;
     }
 
     protected ValueTask<TEntity?> FindTrackedOrLoadNewAsync(TIdentity id, Func<DbSet<TEntity>, Task<TEntity?>> query)

src/Domain/LeanCode.DomainModels.EF/EFRepository.cs

@@ -41,12 +41,14 @@ public virtual void Delete(TEntity entity)
 
     public virtual void DeleteRange(IEnumerable<TEntity> entities)
     {
-        foreach (var oc in entities.OfType<IOptimisticConcurrency>())
+        var entitiesList = entities.ToList();
+
+        foreach (var oc in entitiesList.OfType<IOptimisticConcurrency>())
         {
             oc.DateModified = Time.UtcNow;
         }
 
-        DbSet.RemoveRange(entities);
+        DbSet.RemoveRange(entitiesList);
     }
 
     public virtual void Update(TEntity entity)

src/Domain/LeanCode.DomainModels.EF/ModelBuilderExtensions.cs

@@ -71,7 +71,7 @@ public static void EnableOptimisticConcurrency<TEntity, TRowVersion>(
     )
         where TEntity : class, IOptimisticConcurrency
     {
-        builder.Entity<TEntity>().IsOptimisticConcurrent(useExplicitBackingFields, addRowVersion);
+        builder.Entity<TEntity>().IsOptimisticConcurrent<TEntity, TRowVersion>(useExplicitBackingFields, addRowVersion);
     }
 
     private static string GetBackingFieldFor<TEntity>(string fieldName)

src/Domain/LeanCode.DomainModels.EF/SimpleEFRepository.cs

@@ -5,8 +5,8 @@ namespace LeanCode.DomainModels.EF;
 
 public sealed class SimpleEFRepository<TEntity, TIdentity, TContext> : EFRepository<TEntity, TIdentity, TContext>
     where TEntity : class, IAggregateRoot<TIdentity>
-    where TIdentity : notnull, IEquatable<TIdentity>
-    where TContext : notnull, DbContext
+    where TIdentity : IEquatable<TIdentity>
+    where TContext : DbContext
 {
     public SimpleEFRepository(TContext dbContext)
         : base(dbContext) { }

src/Domain/LeanCode.DomainModels.Generators/TypedIdFormat.cs

@@ -1,6 +1,6 @@
 namespace LeanCode.DomainModels.Generators;
 
-public enum TypedIdFormat : int
+public enum TypedIdFormat
 {
     RawInt = 0,
     RawLong = 1,

src/Domain/LeanCode.DomainModels/Ids/ITypedId.cs

@@ -16,15 +16,15 @@ public interface IPrefixedTypedId<TSelf>
     where TSelf : struct, IPrefixedTypedId<TSelf>
 {
     string Value { get; }
-    public static abstract int RawLength { get; }
-    public static abstract TSelf Parse(string v);
-    public static abstract bool IsValid(string? v);
+    static abstract int RawLength { get; }
+    static abstract TSelf Parse(string v);
+    static abstract bool IsValid(string? v);
 
     [EditorBrowsable(EditorBrowsableState.Never)]
-    public static abstract Expression<Func<string, TSelf>> FromDatabase { get; }
+    static abstract Expression<Func<string, TSelf>> FromDatabase { get; }
 
     [EditorBrowsable(EditorBrowsableState.Never)]
-    public static abstract Expression<Func<TSelf, TSelf, bool>> DatabaseEquals { get; }
+    static abstract Expression<Func<TSelf, TSelf, bool>> DatabaseEquals { get; }
 }
 
 [SuppressMessage("?", "CA1000", Justification = "Roslyn bug.")]
@@ -39,11 +39,11 @@ public interface IRawTypedId<TBacking, TSelf>
     where TSelf : struct, IRawTypedId<TBacking, TSelf>
 {
     TBacking Value { get; }
-    public static abstract TSelf Parse(TBacking v);
+    static abstract TSelf Parse(TBacking v);
 
     [EditorBrowsable(EditorBrowsableState.Never)]
-    public static abstract Expression<Func<TBacking, TSelf>> FromDatabase { get; }
+    static abstract Expression<Func<TBacking, TSelf>> FromDatabase { get; }
 
     [EditorBrowsable(EditorBrowsableState.Never)]
-    public static abstract Expression<Func<TSelf, TSelf, bool>> DatabaseEquals { get; }
+    static abstract Expression<Func<TSelf, TSelf, bool>> DatabaseEquals { get; }
 }

src/Domain/LeanCode.DomainModels/Ids/TypedIdAttribute.cs

@@ -6,7 +6,7 @@ namespace LeanCode.DomainModels.Ids;
 /// <remarks>
 /// See <see href="../../../../docs/domain/ids.md">documentation</see> for more details.
 /// </remarks>
-public enum TypedIdFormat : int
+public enum TypedIdFormat
 {
     /// <summary>
     /// Raw <see cref="int" />, without prefix. It's backing type is <see cref="int" />.

src/Domain/LeanCode.DomainModels/Ids/TypedIdConverter.cs

@@ -122,7 +122,9 @@ public override void WriteAsPropertyName(Utf8JsonWriter writer, TId value, JsonS
 
     private bool TryGetGuidCore(ref Utf8JsonReader reader, out Guid value)
     {
+#pragma warning disable RedundantAssignment
         ReadOnlySpan<byte> span = stackalloc byte[0];
+#pragma warning restore RedundantAssignment
 
         if (reader.HasValueSequence)
         {

src/Domain/LeanCode.DomainModels/Model/Id.cs

@@ -14,7 +14,9 @@ namespace LeanCode.DomainModels.Model;
 public readonly struct Id<TEntity> : IEquatable<Id<TEntity>>, IComparable<Id<TEntity>>
     where TEntity : class, IEntity<Id<TEntity>>
 {
+#pragma warning disable UnassignedReadonlyField
     public static readonly Id<TEntity> Empty;
+#pragma warning restore UnassignedReadonlyField
 
     public Guid Value { get; }
 
@@ -63,7 +65,9 @@ public Id(Guid value)
 public readonly struct IId<TEntity> : IEquatable<IId<TEntity>>, IComparable<IId<TEntity>>
     where TEntity : class, IEntity<IId<TEntity>>
 {
+#pragma warning disable UnassignedReadonlyField
     public static readonly IId<TEntity> Empty;
+#pragma warning restore UnassignedReadonlyField
 
     public int Value { get; }
 

src/Domain/LeanCode.DomainModels/Model/SId.cs

@@ -38,7 +38,7 @@ public SId(Guid v)
     public static SId<TEntity> New() => new(Guid.NewGuid());
 
     [return: NotNullIfNotNull("id")]
-    public static SId<TEntity>? FromNullable(string? id) => id is string v ? From(v) : (SId<TEntity>?)null;
+    public static SId<TEntity>? FromNullable(string? id) => id is string v ? From(v) : null;
 
     public static bool TryParse(string? v, out SId<TEntity> id)
     {
@@ -88,7 +88,7 @@ public static bool TryParseFromGuidOrSId([NotNullWhen(true)] string? v, out SId<
     {
         if (IsValid(v))
         {
-            id = new SId<TEntity>(v!);
+            id = new SId<TEntity>(v);
             return true;
         }
         else if (Guid.TryParse(v, out var guid))

src/Domain/LeanCode.DomainModels/Model/TimestampTz.cs

@@ -6,7 +6,7 @@ namespace LeanCode.DomainModels.Model;
 /// This type is intended to be used with PostgreSQL which supports AT TIME ZONE operator
 /// with IANA time zone IDs but cannot store both timestamp and offset in a single column.
 /// </remarks>
-public sealed record class TimestampTz : ValueObject
+public sealed record TimestampTz : ValueObject
 {
     [JsonIgnore]
     public TimeZoneInfo TimeZoneInfo => TimeZoneInfo.FindSystemTimeZoneById(TimeZoneId);

src/Domain/LeanCode.DomainModels/Model/TypedIdConverterAttribute.cs

@@ -77,7 +77,9 @@ public override void WriteAsPropertyName(Utf8JsonWriter writer, Id<T> value, Jso
 
         private bool TryGetGuidCore(ref Utf8JsonReader reader, out Guid value)
         {
+#pragma warning disable RedundantAssignment
             ReadOnlySpan<byte> span = stackalloc byte[0];
+#pragma warning restore RedundantAssignment
 
             if (reader.HasValueSequence)
             {

src/Domain/LeanCode.DomainModels/Ulids/Ulid.cs

@@ -41,12 +41,7 @@ namespace LeanCode.DomainModels.Ulids;
 [DebuggerDisplay("{ToString(),nq}")]
 [System.Text.Json.Serialization.JsonConverter(typeof(UlidJsonConverter))]
 [System.ComponentModel.EditorBrowsable(System.ComponentModel.EditorBrowsableState.Never)]
-public readonly record struct Ulid
-    : IEquatable<Ulid>,
-        IComparable<Ulid>,
-        ISpanFormattable,
-        ISpanParsable<Ulid>,
-        IUtf8SpanFormattable
+public readonly record struct Ulid : IComparable<Ulid>, ISpanFormattable, ISpanParsable<Ulid>, IUtf8SpanFormattable
 {
     public const int LengthInTextElements = 26;
 
@@ -193,7 +188,9 @@ public readonly record struct Ulid
         new byte[] { 255, 255, 255, 255, 255, 255, 255, 255, 255, 255 }
     );
 
+#pragma warning disable UnassignedReadonlyField
     public static readonly Ulid Empty;
+#pragma warning restore UnassignedReadonlyField
 
     // Core
 
@@ -250,8 +247,7 @@ public readonly record struct Ulid
     [IgnoreDataMember]
     [SuppressMessage("?", "CA1819", Justification = "Fresh array is allocated per call")]
     public byte[] Random =>
-        new byte[]
-        {
+        [
             randomness0,
             randomness1,
             randomness2,
@@ -262,7 +258,7 @@ public readonly record struct Ulid
             randomness7,
             randomness8,
             randomness9,
-        };
+        ];
 
     [IgnoreDataMember]
     public DateTimeOffset Time