[CORELIB-182] Fix dotnet and rider warnings, remove StyleCop leftovers

.editorconfig

@@ -192,7 +192,24 @@ dotnet_naming_symbols.everything_else.applicable_accessibilities   = *
 dotnet_diagnostic.CA1812.severity = none
 dotnet_diagnostic.CA1724.severity = none
 dotnet_diagnostic.CA1515.severity = none
+dotnet_diagnostic.CA2007.severity = none
+dotnet_diagnostic.CA1707.severity = none
+dotnet_diagnostic.CA1062.severity = none
+dotnet_diagnostic.CA1816.severity = none
+dotnet_diagnostic.CA1303.severity = none
+dotnet_diagnostic.CA1002.severity = none
+dotnet_diagnostic.CA1032.severity = none
+dotnet_diagnostic.CA1034.severity = none
+dotnet_diagnostic.CA1019.severity = none
+dotnet_diagnostic.CA1308.severity = none
 dotnet_diagnostic.IDE0058.severity = none
 
 # Disable temporarily
 dotnet_diagnostic.xUnit1051.severity = none
+
+# Rider
+resharper_inconsistent_naming_highlighting=hint
+
+[test-bed/**/*.cs]
+resharper_not_null_or_required_member_is_not_initialized_highlighting = none
+resharper_class_never_instantiated_global_highlighting = none

src/CQRS/LeanCode.CQRS.AspNetCore/CQRSEndpointRouteBuilderExtensions.cs

@@ -40,9 +40,9 @@ public class CQRSPipelineBuilder
 {
     public Func<CQRSObjectMetadata, bool> ObjectsFilter { get; set; } = _ => true;
 
-    public Action<ICQRSApplicationBuilder> Commands { get; set; } = app => { };
-    public Action<ICQRSApplicationBuilder> Queries { get; set; } = app => { };
-    public Action<ICQRSApplicationBuilder> Operations { get; set; } = app => { };
+    public Action<ICQRSApplicationBuilder> Commands { get; set; } = _ => { };
+    public Action<ICQRSApplicationBuilder> Queries { get; set; } = _ => { };
+    public Action<ICQRSApplicationBuilder> Operations { get; set; } = _ => { };
 
     private readonly IEndpointRouteBuilder routeBuilder;
 

src/CQRS/LeanCode.CQRS.AspNetCore/Local/Context/LocalCallContext.cs

@@ -16,8 +16,8 @@ internal class LocalCallContext : HttpContext, IDisposable
 
     public override IFeatureCollection Features => features;
 
-    public override ClaimsPrincipal User { get; set; }
-    public override string TraceIdentifier { get; set; }
+    public sealed override ClaimsPrincipal User { get; set; }
+    public sealed override string TraceIdentifier { get; set; }
     public override HttpRequest Request { get; }
     public override HttpResponse Response { get; }
 

src/CQRS/LeanCode.CQRS.AspNetCore/Middleware/CQRSMiddleware.cs

@@ -1,5 +1,4 @@
 using System.Diagnostics.CodeAnalysis;
-using System.Diagnostics.Metrics;
 using LeanCode.CQRS.AspNetCore.Serialization;
 using LeanCode.CQRS.Execution;
 using Microsoft.AspNetCore.Http;

src/CQRS/LeanCode.CQRS.AspNetCore/Registration/CQRSApiDescriptionProvider.cs

@@ -2,7 +2,6 @@
 using System.Text;
 using LeanCode.Contracts;
 using LeanCode.CQRS.Execution;
-using Microsoft.AspNetCore.Http;
 using Microsoft.AspNetCore.Mvc.Abstractions;
 using Microsoft.AspNetCore.Mvc.ApiExplorer;
 using Microsoft.AspNetCore.Mvc.ModelBinding;

src/CQRS/LeanCode.CQRS.AspNetCore/Registration/CQRSObjectsRegistrationSource.cs

@@ -44,9 +44,9 @@ public void AddCQRSObjects(TypesCatalog contractsCatalog, TypesCatalog handlersC
                 continue;
             }
 
-            var handlerCandidates = handlers[contract];
+            var handlerCandidates = handlers[contract].ToList();
 
-            if (handlerCandidates.Count() != 1)
+            if (handlerCandidates.Count != 1)
             {
                 // TODO: shouldn't we throw here?
                 continue;

src/CQRS/LeanCode.CQRS.AspNetCore/Serialization/ISerializer.cs

@@ -1,5 +1,4 @@
 using System.Text.Json;
-using LeanCode.Serialization;
 using Microsoft.AspNetCore.Http.Json;
 using Microsoft.Extensions.Options;
 

src/CQRS/LeanCode.CQRS.AspNetCore/ServiceCollectionCQRSExtensions.cs

@@ -11,7 +11,6 @@
 using Microsoft.AspNetCore.Routing;
 using Microsoft.Extensions.DependencyInjection;
 using Microsoft.Extensions.DependencyInjection.Extensions;
-using Microsoft.Extensions.Options;
 
 namespace LeanCode.CQRS.AspNetCore;
 

src/CQRS/LeanCode.CQRS.Execution/CommandHandlerNotFoundException.cs

@@ -1,5 +1,3 @@
-using System;
-
 namespace LeanCode.CQRS.Execution;
 
 public class CommandHandlerNotFoundException : Exception

src/CQRS/LeanCode.CQRS.Execution/ICommandHandler.cs

@@ -1,4 +1,3 @@
-using System.Threading.Tasks;
 using LeanCode.Contracts;
 using Microsoft.AspNetCore.Http;
 

src/CQRS/LeanCode.CQRS.Execution/IOperationHandler.cs

@@ -1,4 +1,3 @@
-using System.Threading.Tasks;
 using LeanCode.Contracts;
 using Microsoft.AspNetCore.Http;
 

src/CQRS/LeanCode.CQRS.Execution/IQueryHandler.cs

@@ -1,4 +1,3 @@
-using System.Threading.Tasks;
 using LeanCode.Contracts;
 using Microsoft.AspNetCore.Http;
 

src/CQRS/LeanCode.CQRS.Execution/OperationHandlerNotFoundException.cs

@@ -1,5 +1,3 @@
-using System;
-
 namespace LeanCode.CQRS.Execution;
 
 public class OperationHandlerNotFoundException : Exception

src/CQRS/LeanCode.CQRS.Execution/QueryHandlerNotFoundException.cs

@@ -1,5 +1,3 @@
-using System;
-
 namespace LeanCode.CQRS.Execution;
 
 public class QueryHandlerNotFoundException : Exception

src/CQRS/LeanCode.CQRS.RemoteHttp.Client/Exceptions.cs

@@ -1,4 +1,3 @@
-using System;
 using System.Net;
 
 namespace LeanCode.CQRS.RemoteHttp.Client;

src/CQRS/LeanCode.CQRS.RemoteHttp.Client/HttpCommandsExecutor.cs

@@ -1,12 +1,7 @@
-using System;
 using System.Collections.Immutable;
-using System.IO;
-using System.Linq;
 using System.Net;
-using System.Net.Http;
 using System.Net.Http.Json;
 using System.Text.Json;
-using System.Threading.Tasks;
 using LeanCode.Contracts;
 using LeanCode.Contracts.Validation;
 
@@ -30,7 +25,7 @@ public virtual async Task<CommandResult> RunAsync(ICommand command, Cancellation
     {
         using var content = JsonContent.Create(command, command.GetType(), options: serializerOptions);
         using var response = await client.PostAsync(
-            "command/" + command.GetType().FullName,
+            new Uri("command/" + command.GetType().FullName, UriKind.Relative),
             content,
             cancellationToken
         );

src/CQRS/LeanCode.CQRS.RemoteHttp.Client/HttpOperationsExecutor.cs

@@ -25,7 +25,7 @@ public virtual async Task<TResult> GetAsync<TResult>(
     {
         using var content = JsonContent.Create(operation, operation.GetType(), options: serializerOptions);
         using var response = await client.PostAsync(
-            "operation/" + operation.GetType().FullName,
+            new Uri("operation/" + operation.GetType().FullName, UriKind.Relative),
             content,
             cancellationToken
         );

src/CQRS/LeanCode.CQRS.RemoteHttp.Client/HttpQueriesExecutor.cs

@@ -1,8 +1,5 @@
-using System;
-using System.Net.Http;
 using System.Net.Http.Json;
 using System.Text.Json;
-using System.Threading.Tasks;
 using LeanCode.Contracts;
 
 namespace LeanCode.CQRS.RemoteHttp.Client;
@@ -27,7 +24,11 @@ public virtual async Task<TResult> GetAsync<TResult>(
     )
     {
         using var content = JsonContent.Create(query, query.GetType(), options: serializerOptions);
-        using var response = await client.PostAsync("query/" + query.GetType().FullName, content, cancellationToken);
+        using var response = await client.PostAsync(
+            new Uri("query/" + query.GetType().FullName, UriKind.Relative),
+            content,
+            cancellationToken
+        );
 
         response.HandleCommonCQRSErrors<QueryNotFoundException, InvalidQueryException>();
 

src/CQRS/LeanCode.CQRS.RemoteHttp.Client/HttpResponseMessageExtensions.cs

@@ -1,5 +1,3 @@
-using System;
-using System.Net.Http;
 using static System.Net.HttpStatusCode;
 
 namespace LeanCode.CQRS.RemoteHttp.Client;

src/CQRS/LeanCode.CQRS.Security/ClaimsPrincipalExtensions.cs

@@ -1,4 +1,3 @@
-using System.Linq;
 using System.Security.Claims;
 
 namespace LeanCode.CQRS.Security;

src/CQRS/LeanCode.CQRS.Security/CustomAuthorizerNotFoundException.cs

@@ -1,5 +1,3 @@
-using System;
-
 namespace LeanCode.CQRS.Security;
 
 public class CustomAuthorizerNotFoundException : Exception

src/CQRS/LeanCode.CQRS.Security/DefaultPermissionAuthorizer.cs

@@ -1,7 +1,5 @@
 using System.Security.Claims;
-using System.Threading.Tasks;
 using LeanCode.Contracts.Security;
-using Microsoft.AspNetCore.Http;
 
 namespace LeanCode.CQRS.Security;
 

src/CQRS/LeanCode.CQRS.Security/Exceptions/InsufficientPermissionException.cs

@@ -1,5 +1,3 @@
-using System;
-
 namespace LeanCode.CQRS.Security.Exceptions;
 
 public class InsufficientPermissionException : Exception

src/CQRS/LeanCode.CQRS.Security/Exceptions/UnauthenticatedException.cs

@@ -1,5 +1,3 @@
-using System;
-
 namespace LeanCode.CQRS.Security.Exceptions;
 
 public class UnauthenticatedException : Exception

src/CQRS/LeanCode.CQRS.Security/IRoleRegistration.cs

@@ -1,5 +1,3 @@
-using System.Collections.Generic;
-
 namespace LeanCode.CQRS.Security;
 
 public interface IRoleRegistration

src/CQRS/LeanCode.CQRS.Security/Role.cs

@@ -1,5 +1,3 @@
-using System;
-using System.Collections.Generic;
 using System.Collections.Immutable;
 
 namespace LeanCode.CQRS.Security;

src/CQRS/LeanCode.CQRS.Security/RoleRegistry.cs

@@ -1,6 +1,4 @@
-using System.Collections.Generic;
 using System.Collections.Immutable;
-using System.Linq;
 
 namespace LeanCode.CQRS.Security;
 

src/CQRS/LeanCode.CQRS.Validation/ICommandValidator.cs

@@ -1,4 +1,3 @@
-using System.Threading.Tasks;
 using LeanCode.Contracts;
 using LeanCode.Contracts.Validation;
 using Microsoft.AspNetCore.Http;

src/Core/LeanCode.Components/TypesCatalog.cs

@@ -1,6 +1,4 @@
-using System;
 using System.Diagnostics.CodeAnalysis;
-using System.Linq;
 using System.Reflection;
 
 namespace LeanCode.Components;

src/Core/LeanCode.Startup.Autofac/LeanProgram.cs

@@ -1,4 +1,3 @@
-using System.IO;
 using Autofac.Extensions.DependencyInjection;
 using Microsoft.AspNetCore.Hosting;
 using Microsoft.Extensions.Configuration;

src/Domain/LeanCode.DomainModels.EF/DbContextExtensions.cs

@@ -1,4 +1,3 @@
-using System.Linq;
 using LeanCode.DomainModels.Model;
 using Microsoft.EntityFrameworkCore;
 

src/Domain/LeanCode.DomainModels.EF/ModelBuilderExtensions.cs

@@ -1,5 +1,3 @@
-using System;
-using System.Linq.Expressions;
 using System.Reflection;
 using LeanCode.DomainModels.Model;
 using Microsoft.EntityFrameworkCore;

src/Domain/LeanCode.DomainModels/DataAccess/IRepository.cs

@@ -1,6 +1,3 @@
-using System.Collections.Generic;
-using System.Threading;
-using System.Threading.Tasks;
 using LeanCode.DomainModels.Model;
 
 namespace LeanCode.DomainModels.DataAccess;

src/Domain/LeanCode.DomainModels/Model/DomainEvents.cs

@@ -1,3 +1,5 @@
+using System.Diagnostics.CodeAnalysis;
+
 namespace LeanCode.DomainModels.Model;
 
 public static class DomainEvents
@@ -9,6 +11,7 @@ public static void SetInterceptor(IDomainEventInterceptor interceptor)
         EventInterceptor = interceptor;
     }
 
+    [SuppressMessage("?", "CA1030", Justification = "Convention for `DomainEvents`.")]
     public static void Raise<TEvent>(TEvent domainEvent)
         where TEvent : class, IDomainEvent
     {

src/Domain/LeanCode.DomainModels/Model/IDomainEvent.cs

@@ -1,5 +1,3 @@
-using System;
-
 namespace LeanCode.DomainModels.Model;
 
 public interface IDomainEvent

src/Domain/LeanCode.DomainModels/Model/IOptimisticConcurrency.cs

@@ -1,5 +1,3 @@
-using System;
-
 namespace LeanCode.DomainModels.Model;
 
 public interface IOptimisticConcurrency

src/Domain/LeanCode.DomainModels/Ulids/Ulid.cs

@@ -355,6 +355,7 @@ internal Ulid(ReadOnlySpan<char> base32)
     // HACK: We assume the layout of a Guid is the following:
     // Int32, Int16, Int16, Int8, Int8, Int8, Int8, Int8, Int8, Int8, Int8
     // source: https://github.com/dotnet/runtime/blob/4f9ae42d861fcb4be2fcd5d3d55d5f227d30e723/src/libraries/System.Private.CoreLib/src/System/Guid.cs
+    [SuppressMessage("?", "CA1720", Justification = "Vendored code.")]
     public Ulid(Guid guid)
     {
         Span<byte> buf = stackalloc byte[16];

src/Infrastructure/LeanCode.ClientCredentialsHandler/ClientCredentialsHandler.cs

@@ -1,9 +1,5 @@
-using System;
 using System.Net;
-using System.Net.Http;
 using System.Net.Http.Headers;
-using System.Threading;
-using System.Threading.Tasks;
 using IdentityModel.Client;
 
 namespace LeanCode.ClientCredentialsHandler;

src/Infrastructure/LeanCode.Dapper/DbContextExtensions.cs

@@ -1,10 +1,6 @@
-using System;
-using System.Collections.Generic;
 using System.Data;
 using System.Data.Common;
 using System.Diagnostics.CodeAnalysis;
-using System.Threading;
-using System.Threading.Tasks;
 using Dapper;
 using Microsoft.EntityFrameworkCore;
 using Microsoft.EntityFrameworkCore.Infrastructure;

src/Infrastructure/LeanCode.Dapper/RawQueryValidator.cs

@@ -1,8 +1,5 @@
-using System;
-using System.Linq;
 using System.Reflection;
 using System.Text.RegularExpressions;
-using System.Threading.Tasks;
 using Microsoft.Data.SqlClient;
 
 namespace LeanCode.Dapper;

src/Infrastructure/LeanCode.Dapper/RawSqlQueryAttribute.cs

@@ -1,5 +1,3 @@
-using System;
-
 namespace LeanCode.Dapper;
 
 [AttributeUsage(AttributeTargets.Field, Inherited = false, AllowMultiple = false)]

src/Infrastructure/LeanCode.Firebase.FCM/FCMSendException.cs

@@ -1,5 +1,3 @@
-using System;
-
 namespace LeanCode.Firebase.FCM;
 
 public class FCMSendException : Exception

src/Infrastructure/LeanCode.Firebase.FCM/ModelBuilderExtensions.cs

@@ -1,5 +1,4 @@
 using Microsoft.EntityFrameworkCore;
-using Microsoft.EntityFrameworkCore.Metadata.Builders;
 
 namespace LeanCode.Firebase.FCM;
 

src/Infrastructure/LeanCode.Firebase.FCM/PushNotificationTokenEntity.cs

@@ -1,5 +1,3 @@
-using LeanCode.TimeProvider;
-
 namespace LeanCode.Firebase.FCM;
 
 public sealed record class PushNotificationTokenEntity<TUserId>(TUserId UserId, string Token, DateTime DateCreated)

src/Infrastructure/LeanCode.Firebase.Firestore/FirestoreDatabase.cs

@@ -1,6 +1,3 @@
-using System;
-using System.Threading;
-using System.Threading.Tasks;
 using FirebaseAdmin;
 using Google.Api.Gax;
 using Google.Cloud.Firestore;

src/Infrastructure/LeanCode.Localization/LocalizationConfiguration.cs

@@ -1,5 +1,3 @@
-using System;
-
 namespace LeanCode.Localization;
 
 public sealed class LocalizationConfiguration

src/Infrastructure/LeanCode.Localization/StringLocalizers/ResourceManagerStringLocalizer.cs

@@ -1,4 +1,3 @@
-using System;
 using System.Globalization;
 using System.Resources;
 using static System.Globalization.CultureInfo;

src/Infrastructure/LeanCode.Logging/BaseSanitizer.cs

@@ -1,4 +1,3 @@
-using System;
 using System.Diagnostics.CodeAnalysis;
 using Serilog.Core;
 using Serilog.Events;

src/Infrastructure/LeanCode.Logging/IHostBuilderExtensions.cs

@@ -69,7 +69,7 @@ public static IHostBuilder ConfigureDefaultLogging(
 
                 if (configuration.GetValue<string>(SeqEndpointKey) is string seqEndpoint)
                 {
-                    loggerConfiguration.WriteTo.Seq(seqEndpoint);
+                    loggerConfiguration.WriteTo.Seq(seqEndpoint, formatProvider: CultureInfo.InvariantCulture);
                 }
 
                 if (context.HostingEnvironment.IsDevelopment())

src/Infrastructure/LeanCode.Logging/UserIdLogsCorrelationMiddleware.cs

@@ -1,4 +1,3 @@
-using System;
 using System.Security.Claims;
 using Microsoft.AspNetCore.Builder;
 using Microsoft.AspNetCore.Http;