Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update packages and reformat code with newer CSharpier #644

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

jakubfijalkowski
Copy link
Member

This is mostly a grand reformat, nothing interesting

Copy link

github-actions bot commented Feb 9, 2024

Test Results

 35 files  ±0  136 suites  ±0   1m 9s ⏱️ +5s
772 tests ±0  759 ✅ ±0  13 💤 ±0  0 ❌ ±0 
788 runs  ±0  768 ✅ ±0  20 💤 ±0  0 ❌ ±0 

Results for commit c3fb8ce. ± Comparison against base commit 03b8bfc.

Copy link

codecov bot commented Feb 9, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (03b8bfc) 65.81% compared to head (c3fb8ce) 65.56%.

Files Patch % Lines
...entityServerKeyVaultServiceCollectionExtensions.cs 0.00% 4 Missing ⚠️
...ure/LeanCode.OpenTelemetry/ActivityLogsEnricher.cs 0.00% 2 Missing ⚠️
...tCore/Local/Context/NullRequestCookieCollection.cs 0.00% 1 Missing ⚠️
...in/LeanCode.DomainModels.EF/DbContextExtensions.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           v8.1-preview     #644      +/-   ##
================================================
- Coverage         65.81%   65.56%   -0.26%     
================================================
  Files               263      263              
  Lines              6097     6032      -65     
  Branches            381      381              
================================================
- Hits               4013     3955      -58     
+ Misses             1974     1967       -7     
  Partials            110      110              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Saancreed Saancreed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could have split package updates from CSharpier bump and reformatting as separate PRs, in which case the former would be more attractive for reviewers and the latter would be self-approve material.

@jakubfijalkowski jakubfijalkowski merged commit 3504489 into v8.1-preview Feb 12, 2024
8 of 9 checks passed
@jakubfijalkowski jakubfijalkowski deleted the update-packages branch February 12, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants