Bump server contracts generator version to 3.0.0 and allow overriding it via config file #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alszczep
approved these changes
Nov 25, 2024
konowrockis
approved these changes
Nov 25, 2024
plugins/admin/README.md
Outdated
| @@ -9,6 +9,8 @@ Plugin for generating api components schema from `AdminQuery` queries. This sche | |||
| paths are relative to directory from your current CWD. Unless you are using JavaScript files - in that case you can | |||
| use `__dirname` and `path.join`/`path.resolve` for paths relative to configuration file. | |||
|
|
|||
| - `serverVersion` - version of the contracts generator that should be used. Default: `3.0.0` | |||
There was a problem hiding this comment.
I think that we won't remember to update this default 😅
There was a problem hiding this comment.
We will update it the next time something doesn't work because of too old server version :kekw:
There was a problem hiding this comment.
I mean we won't update it in readme ;)
There was a problem hiding this comment.
Yeah, you are right
BeerHobbyist
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.