Update Categories #276
Open
Update Categories #276
+606
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0de2d38 to
142c1ab
Compare
TheTedder
requested changes
Jan 24, 2025
|
|
||
| UpdateCategoryRequest updateRequest = new() | ||
| { | ||
| Name = "new update", |
There was a problem hiding this comment.
Test updating the other fields too.
| { | ||
| Email = email, | ||
| Password = "Passw0rd", | ||
| Username = $"CreateCatTest{role}" |
There was a problem hiding this comment.
Change this to UpdateCatTest{role}.
|
|
||
| if (slug is not null) | ||
| { | ||
| problemDetails!.Errors["Slug"].ToArray().Should().Equal([SlugRule.SLUG_FORMAT]); |
There was a problem hiding this comment.
Why is the ToArray() call needed here?
There was a problem hiding this comment.
Guess it wasn't. Thought it was.
| [TestCase(1, "b.b")] | ||
| [TestCase(2, "b")] | ||
| [TestCase(3, null)] | ||
| public static async Task UpdateCategory_BadData(int index, string? slug) |
There was a problem hiding this comment.
What is the index param doing here?
There was a problem hiding this comment.
To act as a differentiator for the cats I create. Can't add slug to the cats' slugs
Comment on lines
78
to
82
| [SwaggerResponse( | ||
| 409, | ||
| "The specified slug is already in use by another category. Returns the conflicting category.", | ||
| typeof(CategoryViewModel) | ||
| )] |
There was a problem hiding this comment.
Should we use a Conflict Details here?
There was a problem hiding this comment.
Oh yeah of course. Sorry it slipped my mind. (Peer reviewing really does work, after all)
TheTedder
requested changes
Jan 24, 2025
6808359 to
409025f
Compare
409025f to
e9fee4f
Compare
- Change UpdateCategory 409 to return a ConflictDetails - Change UpdateCategory tests to directly call DB instead for scaffolding
e9fee4f to
fcebb97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #263
Depends: #275