This repository has been archived by the owner on May 25, 2019. It is now read-only.
Backport some changes from #29 + regex SvgSize #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
April 1, 2015 00:17
Port changes from unfinished multiple image select branch
The problem is I made many architectural changes on that branch which I want to complete, so backporting some of them is a pain (and in backporting, I am creating pain when I finally get back to that branch to figure out how to solve the problems and have to merge it back into here).
le717
pushed a commit
that referenced
this pull request
Apr 1, 2015
Regex-powered src/SvgSize module && backports
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
issue-26branch (#29) contains a lot of changes I eventually want to complete, but due to architectural changes and issues I have not yet completed it. This PR backports some of many changes made on that branch, with the rest of the changes must remain unreleased for now.The biggest change is rewriting the entire src/SvgSize.js module to use simple regexs to extract the sizes instead of using jQuery and the DOM to do it. Using regexs for this module was actually my original plan... but I was unable to do it until now.