[BFP 272] ComplexValues #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The complex values were maintaining existing values when they were updated.
The error occured when populating an empty complexValue. The function tries to data from an empty component. This mostly didn't seem to cause an issue, but might have been causing some freeze with the cutter tool. Also, why not catch the error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://staff.loc.gov/tasks/browse/BFP-272
Fixes issue with not being able to edit complex values. The issue was demonstrated as being with names, but other complex values were also showing the issue such as "Geographic Coverage." The issue was that if there was existing data, it would be maintained when the new data was added. The fixes empties out the component before adding the new data.
Also fixes some issues:
complexLookupValue()would throw an error when populating an empty complex value. Related commit has details.