fix(vue.config): should work without git log, close #23

lbwa · May 5, 2020 · faf6c8c · faf6c8c
1 parent 87d130e
commit faf6c8c
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 8 deletions.
diff --git a/src/views/Home.vue b/src/views/Home.vue
@@ -43,8 +43,12 @@ export default {
           href: `https://github.com/lbwa/vue-auth-boilerplate/releases/v${__VERSION__}`
         },
         commit: {
-          label: __COMMIT_HASH__.slice(0, 15),
-          href: `https://github.com/lbwa/vue-auth-boilerplate/commit/${__COMMIT_HASH__}`
+          label: __COMMIT_HASH__
+            ? __COMMIT_HASH__.slice(0, 15)
+            : 'Not a git repository',
+          href: __COMMIT_HASH__
+            ? `https://github.com/lbwa/vue-auth-boilerplate/commit/${__COMMIT_HASH__}`
+            : ''
         },
         latestBuild: new Date(__BUILD_TIME__).toLocaleString()
       })

diff --git a/vue.config.js b/vue.config.js
@@ -10,18 +10,23 @@ module.exports = {
 
   chainWebpack(config) {
     /**
-     * Feature flags
+     * Feature flags in **compiler** time
      * @doc https://webpack.js.org/plugins/define-plugin/#feature-flags
      */
     config.plugin('define').tap(([args]) => {
       args.__DEV__ = JSON.stringify(__DEV__)
       args.__BUILD_TIME__ = JSON.stringify(new Date().toString())
       args.__VERSION__ = JSON.stringify(require('./package.json').version)
-      args.__COMMIT_HASH__ = JSON.stringify(
-        require('child_process')
-          .execSync('git rev-parse HEAD')
-          .toString()
-      )
+      try {
+        args.__COMMIT_HASH__ = JSON.stringify(
+          require('child_process')
+            .execSync('git rev-parse HEAD')
+            .toString()
+        )
+      } catch (err) {
+        // works without git
+        args.__COMMIT_HASH__ = JSON.stringify('')
+      }
       return [args]
     })