Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate to AppImage and publish with electron-builder on Travis #1010

Merged
merged 20 commits into from
Mar 7, 2018

Conversation

IGassmann
Copy link
Contributor

This closes #332 and closes #966.

@IGassmann IGassmann self-assigned this Feb 11, 2018
@IGassmann IGassmann changed the title Issue/332 Migrate to AppImage and change CI/publish workflow Feb 11, 2018
@kauffj
Copy link
Member

kauffj commented Feb 13, 2018

@JoshStrobl apologies if this is a redundant question (I have this feeling I've asked this), but for your purposes does this switch to AppImage: a) help, b) hurt, or c) doesn't matter?

@JoshStrobl
Copy link
Contributor

@kauffj It doesn't affect packaging in my case. ("Doesn't matter.")

@lyoshenka lyoshenka added this to the Mar 12 (app) milestone Feb 26, 2018
@tzarebczan
Copy link
Contributor

@IGassmann per our convo, let's make sure the daemon is signed: lbryio/lbry-sdk#811

@lbryio lbryio deleted a comment Mar 6, 2018
@lbryio lbryio deleted a comment Mar 6, 2018
@lbryio lbryio deleted a comment Mar 6, 2018
@lbryio lbryio deleted a comment Mar 7, 2018
@lbryio lbryio deleted a comment Mar 7, 2018
@lbryio lbryio deleted a comment Mar 7, 2018
@lbryio lbryio deleted a comment Mar 7, 2018
@lbryio lbryio deleted a comment Mar 7, 2018
@IGassmann IGassmann changed the title Migrate to AppImage and change CI/publish workflow chore: migrate to AppImage and publish with electron-builder on Travis Mar 7, 2018
@IGassmann IGassmann merged commit b9f4d7b into master Mar 7, 2018
@IGassmann IGassmann deleted the issue/332 branch March 8, 2018 17:46
@probonopd
Copy link

Now that this has been merged, where did the AppImage go?

@kauffj
Copy link
Member

kauffj commented Dec 20, 2019

@seanyesmunt do you know what happened to AppImage builds or what it would take to re-enable these?

@tzarebczan
Copy link
Contributor

We only temporarily tested with these and decided not to go with them at the time because it required setting the executable properties manually before installing.

With syncing enabled now, I think it will be a good time to check out appimage and snaps.

@probonopd
Copy link

probonopd commented Dec 21, 2019

If you would like to test, here is an example AppImage I've made to be able tor run LBRY until an official AppImage becomes available:

https://github.com/probonopd/LBRY.AppImage/releases/tag/continuous

Before you can run an AppImage, you need to make it executable. This is a Linux security feature. There are three main ways to make an AppImage executable:

1. With the GUI

2. On the command line

chmod a+x Some.AppImage

3. Automatically with the optional appimaged daemon

If you would like to have all AppImages be executable automatically, you can install the optional appimaged daemon. It will automatically add downloaded AppImages to the menu and make them executable for you. It can be downloaded from https://github.com/AppImage/AppImageKit/releases or installed from your distribution.

You can see the .travis.yml I used to make the AppImage here:

https://github.com/probonopd/LBRY.AppImage/blob/master/.travis.yml

If you haven't seen it, also check out this:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Research publishing options and mystery ci upload Use AppImage for Linux builds
6 participants