Added Windows compatibility to build and test scripts #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1 - allows
sbt run
andsbt test
to work out-of-the-box on windows OS (tested on Windows 10 x64) and Mac (tested on OSX El Capitan 10.11.6).Still outstanding issues:
chmod +x normalize_file_names.sh
command, becausechmod
doesn't exist on Windows. Not sure what to do about that, since you can't put OS-checking logic in package.json, could possibly have the postinstall script call some javascript with node that carries out OS-specific commands. This has no effect on the web app running successfully though.sbt test
fails initially with error code 135:Could not find update-config.json. Run 'webdriver-manager update' to download binaries.
This might be related to this angular-cli issue. In any case, this is fixed by runningnpm run pree2e
in the/ui
folder. Maybe we could add that to the normal sbt test hook.