Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop moving Juneteenth to Friday if Saturday for US-Fed calendar #1848

Merged
merged 2 commits into from
Dec 19, 2023

Conversation

gbfredrik
Copy link
Contributor

Hi,
These two links suggest the moving of Juneteenth to Fridays is incorrect for the Federal Reserve implementation:

This currently leads to issues during 2027, 2032, etc. I've added a boolean to isJuneteenth to preserve the behavior for other calendar implementations.

@coveralls
Copy link

coveralls commented Dec 12, 2023

Coverage Status

coverage: 72.136% (+0.02%) from 72.112%
when pulling 9160717 on Model-Validation:juneteenth-fed
into 5611dec on lballabio:master.

@lballabio
Copy link
Owner

Thanks! May you add the links to the docs in the header file?

@gbfredrik
Copy link
Contributor Author

Thanks! May you add the links to the docs in the header file?

Done!

@lballabio lballabio added this to the Release 1.33 milestone Dec 19, 2023
@lballabio lballabio merged commit 9b5df4e into lballabio:master Dec 19, 2023
51 checks passed
@gbfredrik gbfredrik deleted the juneteenth-fed branch January 16, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants