More clang-tidy suggestions, dead link

lballabio · Nov 18, 2024 · e8e8b06 · e8e8b06
1 parent bb4b781
commit e8e8b06
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 6 deletions.
diff --git a/ql/math/interpolations/chebyshevinterpolation.hpp b/ql/math/interpolations/chebyshevinterpolation.hpp
@@ -28,13 +28,9 @@
 #include <ql/math/array.hpp>
 #include <ql/math/interpolation.hpp>
 
-
 namespace QuantLib {
-    /*! References:
-        S.A. Sarra: Chebyshev Interpolation: An Interactive Tour,
-        https://www.maa.org/sites/default/files/images/upload_library/4/vol6/Sarra/Chebyshev.html
-     */
 
+    /*! See S.A. Sarra: Chebyshev Interpolation: An Interactive Tour. */
     class ChebyshevInterpolation: public Interpolation {
       public:
         enum PointsType {FirstKind, SecondKind};
@@ -45,8 +41,11 @@ namespace QuantLib {
             Size n, const std::function<Real(Real)>& f,
             PointsType pointsType = SecondKind);
 
+        ~ChebyshevInterpolation() override = default;
         explicit ChebyshevInterpolation(const ChebyshevInterpolation&) = delete;
+        explicit ChebyshevInterpolation(ChebyshevInterpolation&&) = delete;
         ChebyshevInterpolation& operator=(const ChebyshevInterpolation&) = delete;
+        ChebyshevInterpolation& operator=(ChebyshevInterpolation&&) = delete;
 
         void updateY(const Array& y);
 
@@ -57,6 +56,7 @@ namespace QuantLib {
         const Array x_;
         Array y_;
     };
+
 }
 
 #endif
diff --git a/ql/math/matrixutilities/pseudosqrt.cpp b/ql/math/matrixutilities/pseudosqrt.cpp
@@ -436,7 +436,7 @@ namespace QuantLib {
                        sqrtEigenvalues.begin(), sqrtEigenvalues.end(),
                        jd.eigenvectors().row_begin(i),
                        diagonal.column_begin(i),
-                       std::multiplies<Real>()
+                       std::multiplies<>()
                    );
 
               result = jd.eigenvectors()*diagonal;

diff --git a/ql/pricingengines/basket/fdndimblackscholesvanillaengine.cpp b/ql/pricingengines/basket/fdndimblackscholesvanillaengine.cpp
@@ -215,6 +215,8 @@ namespace QuantLib {
                 break;
             #define BOOST_PP_LOCAL_LIMITS (1, PDE_MAX_SUPPORTED_DIM)
             #include BOOST_PP_LOCAL_ITERATE()
+          default:
+            QL_FAIL("Not implemented for " << processes_.size() << " processes");
         }
 
         if (isEuropean)