Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

urllib3 1.25 and below does not work with this library #25

Closed
99littlebugs opened this issue Feb 27, 2024 · 1 comment · Fixed by #26 or #22
Closed

urllib3 1.25 and below does not work with this library #25

99littlebugs opened this issue Feb 27, 2024 · 1 comment · Fixed by #26 or #22

Comments

@99littlebugs
Copy link

Describe the bug
urllib3 < 1.26.0 does not work with this library even though pyproject.toml allows urllib3 = ">=1.22.0,<3"

To reproduce

  1. Use launchdarkly-server-sdk version 9.2.0 and launchdarkly-eventsource version 1.1.0, along with urllib3 version 1.25.10
  2. When trying to evaluate flags (with streaming turned on), continually get the error Unexpected error on stream connection: __init__() got an unexpected keyword argument 'other', will retry

Expected behavior
No errors and the ability to evaluate flags.

Logs
If applicable, add any log output related to your problem.

SDK version
launchdarkly-server-sdk version 9.2.0 and launchdarkly-eventsource version 1.1.0

Language version, developer tools
Python 3.8.18

OS/platform
N/A

Additional context
Tracing the errors, we've found that this library used the urllib3 retry object here and is passing in other as an argument. urllib3 doesn't support the other keyword prior to 1.26.0 (see MR)
keelerm84 added a commit that referenced this issue Feb 29, 2024
@keelerm84
fix: Raise minimum urllib3 package to 1.26.0
cd352ca 
Our usage of the `Retry` object from the `urllib3` package depends on a
signature that was introduced in v1.26.0.

Fixes #25
@keelerm84 keelerm84 mentioned this issue Feb 29, 2024
Merged
@keelerm84
Copy link
Member

Thank you for bringing this to our attention. I have a PR up now and will let you know once a fix has been released.

keelerm84 added a commit that referenced this issue Mar 1, 2024
@keelerm84
fix: Raise minimum urllib3 package to 1.26.0 (#26)
ca5408d 
Our usage of the `Retry` object from the `urllib3` package depends on a
signature that was introduced in v1.26.0.

Fixes #25
@github-actions github-actions bot mentioned this issue Dec 14, 2023
Merged
keelerm84 pushed a commit that referenced this issue Mar 1, 2024
@github-actions
chore(main): release 1.1.1 (#22)
5701dba 
🤖 I have created a release *beep* *boop*
---


##
[1.1.1](1.1.0...1.1.1)
(2024-03-01)


### Bug Fixes

* **deps:** Bump jsonpickle to fix CVE-2020-22083
([#23](#23))
([3487311](3487311))
* Raise minimum urllib3 package to 1.26.0
([#26](#26))
([ca5408d](ca5408d)),
closes
[#25](#25)


### Documentation

* Add status badge
([#19](#19))
([777330b](777330b))
* Fix GH pages rendering of published docs
([#21](#21))
([0a7ae7a](0a7ae7a))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@keelerm84 @99littlebugs