Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: don't skip .github dir #441

Merged

Conversation

jazanne
Copy link
Contributor

@jazanne jazanne commented Mar 26, 2024

allow scanning for flag keys used in github workflows with https://github.com/launchdarkly/gha-flags

User will need to have delimiters turned off or use proper aliasing to pick them up

User can skip .github files by including them in .ldignore

@jazanne jazanne requested a review from a team March 26, 2024 16:17
Copy link

This pull request has been linked to Shortcut Story #158304: allow scanning github workflows for flag keys.

@jazanne jazanne requested a review from a team March 26, 2024 18:33
Copy link
Contributor

@mmrj mmrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor docs suggestions, lgtm

docs/ALIASES.md Outdated Show resolved Hide resolved
docs/CONFIGURATION.md Outdated Show resolved Hide resolved
Co-authored-by: Molly <molly.jones@launchdarkly.com>
@jazanne jazanne enabled auto-merge (squash) March 27, 2024 13:53
@jazanne jazanne merged commit afe83e5 into main Mar 27, 2024
2 checks passed
@jazanne jazanne deleted the jwhite/sc-158304/allow-scanning-github-workflows-for-flag branch March 27, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants