Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove use of ldclient #438

Merged
merged 14 commits into from
Mar 19, 2024
Merged

remove use of ldclient #438

merged 14 commits into from
Mar 19, 2024

Conversation

jazanne
Copy link
Contributor

@jazanne jazanne commented Mar 12, 2024 •
edited
Loading

We had partially switched to using ld client for requests, but it's easier for us to maintain one client, so I'm removing it and using the main http client for consistency.

Other

  • add a helper for all api paths
  • update to latest ldapi client v15, and latest api version 20220603
  • disable nilnil in linter

@shortcut-integration Shortcut Integration
Copy link

This pull request has been linked to Shortcut Story #236088: code refs client mismatch.

jazanne
jazanne commented Mar 12, 2024
View reviewed changes
options/options.go Outdated Show resolved Hide resolved
jazanne
jazanne commented Mar 12, 2024
View reviewed changes
options/options.go Outdated Show resolved Hide resolved
@jazanne jazanne marked this pull request as ready for review March 12, 2024 16:13
@jazanne jazanne requested review from a team and InTheCloudDan March 12, 2024 16:13
mmrj
mmrj approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@mmrj mmrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ from Docs to unblock you -- looks like we were tagged because there are *.md files in the vendor update, but I only looked at the non-vendor files. Let me know if there's anything you want specific Docs feedback on.

internal/ld/ld.go Outdated Show resolved Hide resolved
@jazanne jazanne mentioned this pull request Mar 14, 2024
Merged
@jazanne jazanne force-pushed the jwhite/sc-236088/code-refs-client-mismatch branch from a1130d0 to 544b3ed Compare March 14, 2024 16:54
@jazanne jazanne force-pushed the jwhite/sc-236088/code-refs-client-mismatch branch from 544b3ed to bb434be Compare March 14, 2024 17:27
@jazanne jazanne merged commit 7c37706 into main Mar 19, 2024
2 checks passed
@jazanne jazanne deleted the jwhite/sc-236088/code-refs-client-mismatch branch March 19, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@InTheCloudDan InTheCloudDan InTheCloudDan approved these changes

@mmrj mmrj mmrj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jazanne @mmrj @InTheCloudDan