[sc-112730] fix: out of range error while running extinctions on large diffs #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves #351, where the tool would throw index out of range errors for sufficiently large source code diffs. The downstream library was recently updated to allow for significantly larger diff max sizes, as discussed in the associated issue.
|
This pull request has been linked to Shortcut Story #112730: Index out of range error when scanning large files. |
karayusuf
approved these changes
Jan 24, 2024
|
Thank you @jazanne! Can we also publish a patch version for this change? |
|
@ffluk3 yes, i expect to have that our later today |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks @ffluk3 for introducing fix in #386
Adds a test case to verify the fix. The test data is taken from sergi/go-diff#89 data.txt
Closes #351