bump go-github to current v68 #145
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of looking at https://launchdarkly.atlassian.net/browse/REL-4888 and the related customer created PR, I noticed that we haven't bumped the
go-githubversion since August 2018 😅.The main reason I'd like to update is that the customer PR wants to use a method to support Enterprise hosted instances which has actually been deprecated in more modern versions of the package.
It looks like there aren't any breaking changes for us to worry about, but there's definitely a lot happening here.
Still need to test these changes for myself, want to get the CI tests running for now.