-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Electron package #165
Electron package #165
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks for working on this!
Co-authored-by: Joel Gallant <code@joelgallant.io>
Co-authored-by: Joel Gallant <code@joelgallant.io>
Co-authored-by: Joel Gallant <code@joelgallant.io>
@johnb8 seems to have timed out tests, not sure why |
Yeah, not really sure what's going on, it doesn't seem to be running the electron tests at all? I added the playwright github action, but since it's electron it should have all the dependencies it needs so I'm not sure if it will help. I'm also not sure if it's a display thing either because I think Windows and MacOS should run it no problem without any display configuration. @joelgallant can you approve the run again? |
Could you approve again @joelgallant? |
Codecov Report
@@ Coverage Diff @@
## master #165 +/- ##
=======================================
Coverage 80.09% 80.09%
=======================================
Files 42 42
Lines 2482 2482
Branches 593 593
=======================================
Hits 1988 1988
Misses 494 494 Continue to review full report at Codecov.
|
@joelgallant are the Windows and MacOS pipelines actually running in those environments? If you look at the |
@joelgallant CI is fixed, I think this is good to go now, unless you see anything else? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the effort in getting this done!
Addresses #57. I couldn't implement it in the same way we do in our LC package since app-config doesn't have synchronous config loading anymore and Electron preload scripts don't wait for promises to resolve. Instead I load the config in the main electron process then pass that through to the renderer. I think this is better than the way we used to do it since the config is now available on the main electron side as well. I'm not sure if there's any concerns using the main
config
object across libraries like I do, but it works.I'll add documentation and tests, just wanted to get your thoughts on how I've done this first.