0.3: Introduce life 🧬 into an otherwise static ⛰️ environment #111

mehcode · 2020-02-22T01:28:26Z

Do not worry about making your PR compatible with `develop`. After the dust settles here, we will integrate each PR into `develop`.

HasSqlType<T>: Database is now T: Type<Database> to mirror Encode and Decode
Row is now Row<'c> where 'c is bound to the lifetime of the Connection where the Row came from
Introduce a Cursor type that is now returned from Query::fetch(); this is simply a futures::Stream where the Item type is a higher-ranked trait bound so we can introduce a lifetime per iteration of the stream. Most usages should remain the same.
Executor is now implemented for &mut Connection and &Pool so hacks like &mut &Pool are no longer needed
Queries from the database are now zero-copy and no allocation beyond a shared read buffer for the TCP stream ( in other words, no per-query allocation )

TLS on Postgres is still unimplemented in the new protocol implementation (all the same code is there, just needs tied together)
Simple queries on postgres that return results
Macros are broken ( cue summoning the amazing @abonander )
Re-add support for query_as (merge old QueryAs with Query)
Support for MySQL ( I understand Postgres a lot more so it was easier for me to experiment in Postgres, but the same concepts should transfer to MySQL )
Postgres / UUID / Text
Postgres / Chrono / Text

sqlx-core/src/connection.rs

sqlx-core/src/cursor.rs

abonander · 2020-02-27T04:10:48Z

@mehcode you should be able to fast-forward merge to ab/dev-fixes which fixes macros and reintroduces query_as(): 66edfed

closes #111

* this breaks a lot internally as-is * mysql needs a restructure

…GATs soon

… type; remove Cursor::first

* Allow `conn.fetch(" ... ")` to be called where `conn` is an owned Connection * Executor::fetch -> RefExecutor::fetch_by_ref * Executor::fetch_by_ref -> Executor::fetch * Move `Connection::describe` to `Executor::describe` * `Transaction` is no longer a `Connection` * `Connection` has `Executor` as a super-trait again which greatly simplifies bounds

…ery::try_map is fallible

mehcode · 2020-03-11T10:45:51Z

@abonander This should be good to go ( tests pass locally ). Any idea why CI is crapping out?

     Running target/debug/deps/ui_tests-339cabbe753a12df

running 1 test
error: failed to download `quote v1.0.3`

Caused by:
  can't make HTTP request in the offline mode
test ui_tests ... FAILED

failures:

---- ui_tests stdout ----
thread 'ui_tests' panicked at 'tests failed', /home/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/trybuild-1.0.23/src/run.rs:38:13
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.

abonander · 2020-03-11T20:09:10Z

dtolnay/trybuild#52 (comment)

…10.1)

mehcode added this to the 0.3 milestone Feb 22, 2020

thedodd reviewed Feb 24, 2020

View reviewed changes

sqlx-core/src/connection.rs Outdated Show resolved Hide resolved

thedodd reviewed Feb 24, 2020

View reviewed changes

sqlx-core/src/cursor.rs Show resolved Hide resolved

abonander changed the title ~~Introduce life 🧬 into an otherwise static environment~~ 0.3: Introduce life 🧬 into an otherwise static environment Mar 3, 2020

abonander mentioned this pull request Mar 3, 2020

Error inside postgres plpgsql stored procedure yields Error::Protocol("received unknown field in Response: 87") #120

Closed

abonander changed the title ~~0.3: Introduce life 🧬 into an otherwise static environment~~ 0.3: Introduce life 🧬 into an otherwise static ⛰️ environment Mar 3, 2020

abonander force-pushed the develop branch 4 times, most recently from 2731838 to ea2af23 Compare March 4, 2020 20:59

This was referenced Mar 6, 2020

question: how to preform query with variable length of param? #103

Closed

Implement support for 1-dim arrays for PostgreSQL #110

Closed

abonander added a commit that referenced this pull request Mar 6, 2020

implement guarded flush for BufStream

2f681c1

closes #111

abonander force-pushed the develop branch 2 times, most recently from 918a4f8 to 15369c9 Compare March 6, 2020 03:20

abonander mentioned this pull request Mar 6, 2020

Documentation of how Database-types and rust-types match needed #124

Closed

mehcode marked this pull request as ready for review March 11, 2020 08:42

mehcode and others added 12 commits March 11, 2020 01:42

remove unused methods from Arguments: is_empty, len, size

d3d58ef

make Connect extend Connection to simplify bounds

bb17ebf

add Cursor and rewrite Executor/Query over it

ea1a4fb

* this breaks a lot internally as-is * mysql needs a restructure

postgres: break out TLS and SASL into their own files

3795d15

postgres: rewrite protocol in more iterative and lazy fashion

a374c18

adjust Cursor::map to work through black magic hacks and hope we get …

7404708

…GATs soon

postgres: add support for simple queries (that do not return results)

55ffd98

make macros work again

0cb7bd1

row: RowIndex -> ColumnIndex and de-duplicate logic with macros

d981262

remove the DB type parameter from HasCursor and push to an associated…

72b60e8

… type; remove Cursor::first

rename Executor::execute to Executor::fetch

0afcf33

mehcode added 8 commits March 11, 2020 01:49

Update Cargo.lock format

d58c533

Run rustfmt

a9c3d9f

Fix TLS refactors for MySQL

d6ce866

Fix tests for MySQL chrono

038a6f2

Annotate the DB type for Decode in Decode for String

e701aef

Remove custom Execute impl (no longer needed)

e047f7c

Add another missing import

f398520

Fix doctests for macros

17f52a8

mehcode force-pushed the develop branch from 032ddcf to 17f52a8 Compare March 11, 2020 09:02

mehcode added 11 commits March 11, 2020 02:18

mysql: initialize sql-mode and other options on establish

69489ca

mysql: fix handling of multiple query statements for affected_rows

0eed8c5

macros: fix trailing commas from rebase

6924b4f

remove unused imports

c14338d

test: postgres: fix query string (form -> from)

63200a5

macros: fix trailing commas one more time from rebase

b9fe70f

remove dead_code allow (lints fixed now)

ffa4420

Run rustfmt

9609a62

row: Row::get panics, Row::try_get is fallible, Query::map panics, Qu…

a165615

…ery::try_map is fallible

postgres: add type test for NULL

7643114

Run rustfmt

0a7415f

abonander force-pushed the develop branch 2 times, most recently from 5fca584 to f1f8822 Compare March 11, 2020 20:20

update trybuild

fdff5ef

abonander force-pushed the develop branch from f1f8822 to fdff5ef Compare March 11, 2020 20:24

abonander and others added 3 commits March 11, 2020 15:43

fix Postgres UI tests for 1.41 stable

a9f0fca

log: trace the MySQL capability flags

12fa401

mysql: handle EOF packets if the server still requires them (MariaDB …

cc88efe

…10.1)

mehcode merged commit d269506 into master Mar 15, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

0.3: Introduce life 🧬 into an otherwise static ⛰️ environment #111

0.3: Introduce life 🧬 into an otherwise static ⛰️ environment #111

mehcode commented Feb 22, 2020 •

edited

Loading

abonander commented Feb 27, 2020 •

edited

Loading

mehcode commented Mar 11, 2020

abonander commented Mar 11, 2020

0.3: Introduce life 🧬 into an otherwise static ⛰️ environment #111

0.3: Introduce life 🧬 into an otherwise static ⛰️ environment #111

Conversation

mehcode commented Feb 22, 2020 • edited Loading

Do not worry about making your PR compatible with develop. After the dust settles here, we will integrate each PR into develop.

abonander commented Feb 27, 2020 • edited Loading

mehcode commented Mar 11, 2020

abonander commented Mar 11, 2020

mehcode commented Feb 22, 2020 •

edited

Loading

Do not worry about making your PR compatible with `develop`. After the dust settles here, we will integrate each PR into `develop`.

abonander commented Feb 27, 2020 •

edited

Loading