Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry setup phase #70

Merged
merged 7 commits into from
Oct 12, 2023
Merged

Retry setup phase #70

merged 7 commits into from
Oct 12, 2023

Conversation

Konboi
Copy link
Collaborator

@Konboi Konboi commented Sep 12, 2023

Our e2e CI sometimes failed to install the dependencies phase.
So, I introduced a retry action

@Konboi Konboi force-pushed the retry-setup-phase branch 2 times, most recently from 6ce9f06 to a7c3d2e Compare September 12, 2023 06:50
@Konboi Konboi requested a review from ono-max October 12, 2023 00:09
python -m pip install --upgrade pip
pip install -r test-requirements.txt
working-directory: ./e2e
uses: nick-fields/retry@v2
Copy link

@ono-max ono-max Oct 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend using hash instead of version in the third party.

@Konboi Konboi force-pushed the retry-setup-phase branch from d99dd7c to 07eee3d Compare October 12, 2023 02:58
@Konboi Konboi force-pushed the retry-setup-phase branch from 07eee3d to b7fc658 Compare October 12, 2023 02:59
@Konboi Konboi requested a review from ono-max October 12, 2023 02:59
Copy link

@ono-max ono-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ono-max
Copy link

ono-max commented Oct 12, 2023

Oops, CI has failed, but it doesn't seem to be related to the change.

@ono-max
Copy link

ono-max commented Oct 12, 2023

I've rerun CI.

from v2 distribution field is required
@Konboi Konboi force-pushed the retry-setup-phase branch from f90a0cc to ff55393 Compare October 12, 2023 03:05
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants