align test session id format with cli command

[Konboi]

launchableinc/cli outputs session builds/{build number}/test_sessions/{test session id} format. like below)

$ launchable record session --build cli
builds/cli/test_sessions/310

However, nose-launchable handle test session id as test_sessions/{test session id}, the cli will fail to parse session https://github.com/launchableinc/cli/blob/1df90eb8ffe42ae6f7deb3f2e1fb6482ec8613f4/launchable/utils/session.py#L102-L111. So, I fixed it.

Before fixing it, the cli only used the base so this issue didn't become a problem https://github.com/launchableinc/cli/blob/1df90eb8ffe42ae6f7deb3f2e1fb6482ec8613f4/launchable/commands/subset.py#L189-L191

[shuheiktgw]

self.test_session_id is used to construct urls for uploading test case results and closing test sessions so I don't think changing self.test_session_id itself is a good idea. Instead, you might want to somehow pass build_name (or build_number) to the subset method.

nose-launchable/nose_launchable/client.py

Lines 113 to 119 in 60f0192

	def upload_events(self, events):
	url = "{}/intake/organizations/{}/workspaces/{}/builds/{}/test_sessions/{}/events".format(
	self.base_url,
	self.org_name,
	self.workspace_name,
	self.build_number,
	self.test_session_id

nose-launchable/nose_launchable/client.py

Lines 128 to 135 in 60f0192

	def finish(self):
	url = "{}/intake/organizations/{}/workspaces/{}/builds/{}/test_sessions/{}/close".format(
	self.base_url,
	self.org_name,
	self.workspace_name,
	self.build_number,
	self.test_session_id
	)

[Konboi]

Hmm, How about change to use fixed test_session_id (buils//test_sessions/ format) in uploading test case results and closing test session?
Because I think we should gather a logic that building test session id in one place.

[shuheiktgw]

That could work, but then the name self.test_session_id looks strange to me since it is not. I don't want to step into how to implement it but If I were you, I would create a new small class like TestSessionContext and store build id and test session id to its instance. Then we can call getTestSessionId or getBuildPath to extract the necessary information.

[shuheiktgw]

Hmm, I'm also wondering why those unite tests did not fail...

nose-launchable/tests/test_client.py

Line 217 in 83beb53

mock_requests.patch.assert_called_once_with(expected_url, headers=expected_headers)

[Konboi]

I think set test_session_id directly so this test didn't fail

nose-launchable/tests/test_client.py

Lines 204 to 205 in 83beb53

	client.build_number = "test_build_number"
	client.test_session_id = "1"

[Konboi]

@shuheiktgw I changed that introduced TestSessionContext and use it. Could you review again?

[shuheiktgw]

Wow, I haven't noticed we could remove self.build_number but this makes sense!

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[shuheiktgw]

LGTM👍 Thank you!