Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support subset #25

Merged
merged 4 commits into from
Jan 18, 2021
Merged

Support subset #25

merged 4 commits into from
Jan 18, 2021

Conversation

shuheiktgw
Copy link
Contributor

@shuheiktgw shuheiktgw commented Jan 15, 2021 •
edited
Loading

Add subset support using the Launchable CLI.

@shuheiktgw shuheiktgw changed the title wip Support subset Jan 18, 2021
@shuheiktgw shuheiktgw marked this pull request as ready for review January 18, 2021 02:05
@shuheiktgw shuheiktgw requested a review from ninjinkun January 18, 2021 02:05
ninjinkun
ninjinkun reviewed Jan 18, 2021
View reviewed changes
requirements.txt Outdated
@@ -1,3 +1,4 @@
launchable>=1.1.3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CLI may change its interface in the future. You have to fix the version to 1.x with launchable >= 1.1.3, ~= 1.0.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I didn't know I can use both >= and =~. Thank you!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ninjinkun Fixed it so would you review the PR again?

ninjinkun
ninjinkun approved these changes Jan 18, 2021
View reviewed changes
Copy link
Contributor

@ninjinkun ninjinkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shuheiktgw
Copy link
Contributor Author

Thank you!

@shuheiktgw shuheiktgw merged commit 8cb2999 into main Jan 18, 2021
@shuheiktgw shuheiktgw deleted the support_subset branch January 18, 2021 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ninjinkun ninjinkun ninjinkun approved these changes

Assignees

@ninjinkun ninjinkun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shuheiktgw @ninjinkun