Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connect busy-signal #1

Merged
merged 3 commits into from
Feb 2, 2018
Merged

Connect busy-signal #1

merged 3 commits into from
Feb 2, 2018

Conversation

laughedelic
Copy link
Owner

@laughedelic laughedelic commented Nov 4, 2017

Start spinning on didSave, stop on publishDiagnostics, show messages from window/logMessage notifications.

https://github.com/facebook-atom/atom-ide-ui/blob/master/modules/atom-ide-ui/pkg/atom-ide-busy-signal/lib/types.js

@laughedelic laughedelic self-assigned this Nov 2, 2017
@laughedelic
Copy link
Owner Author

laughedelic commented Nov 4, 2017

Done, but depends on sbt/sbt#3713 sbt/sbt#3740.

@laughedelic
Copy link
Owner Author

This seems to work regarding busy-signal during compilation, but it gets stuck on server termination and I think it's a but in https://github.com/atom/atom-languageclient/blob/master/lib/server-manager.js#L218

@laughedelic laughedelic merged commit cfd6c06 into master Feb 2, 2018
@laughedelic laughedelic deleted the busy-signal branch February 2, 2018 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant