Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): deprecate create command #424

Merged
merged 1 commit into from
Feb 20, 2023
Merged

Conversation

holic
Copy link
Member

@holic holic commented Feb 20, 2023

Deprecates mud create cli command in favor of yarn create mud. This is a "bridge" commit that deprecates the command but still allows it to run (by using yarn create mud under the hood). In a future version, we should remove this command all together. Happy to do this sooner if you think that's warranted.

Also deprecated+archived the template repos:
https://github.com/latticexyz/mud-template-minimal
https://github.com/latticexyz/mud-template-react

@holic holic marked this pull request as ready for review February 20, 2023 15:18
@holic holic requested a review from alvrs as a code owner February 20, 2023 15:18
@dk1a
Copy link
Contributor

dk1a commented Feb 20, 2023

Didn't realize it was essentially deprecated. I can remove it in #417 then, it'll fit in with the other removals and avoid resolving conflicts with this PR

@holic
Copy link
Member Author

holic commented Feb 20, 2023

Didn't realize it was essentially deprecated. I can remove it in #417 then, it'll fit in with the other removals and avoid resolving conflicts with this PR

Yep, just the create command is deprecated.

I would kinda prefer to keep this deprecation separate from the big refactor, just to minimize blast radius/what's changing. Coupling a big refactor and a deprecation is a little scary to me (in case one breaks). Is that okay?

@dk1a
Copy link
Contributor

dk1a commented Feb 20, 2023

I would kinda prefer to keep this deprecation separate from the big refactor, just to minimize blast radius/what's changing. Coupling a big refactor and a deprecation is a little scary to me (in case one breaks). Is that okay?

Of course, I meant that your PR goes into main soonish, and my refactor with its removals goes into v2 (#417 isn't needed in v1 as its main purpose is to pave the way for autogen)

dk1a added a commit that referenced this pull request Feb 20, 2023
@holic
Copy link
Member Author

holic commented Feb 20, 2023

Of course, I meant that your PR goes into main soonish, and my refactor with its removals goes into v2 (#417 isn't needed in v1 as its main purpose is to pave the way for autogen)

Ohh that sounds perfect. Thank you!

Copy link
Member

@alvrs alvrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@holic holic merged commit 292119f into main Feb 20, 2023
@holic holic deleted the holic/deprecate-mud-create branch February 20, 2023 22:13
dk1a added a commit that referenced this pull request Feb 22, 2023
alvrs pushed a commit that referenced this pull request Feb 22, 2023
* feat(cli): refactor to esm

* feat(services): make services more compatible with esm

* build(cli): add clarifications to tsup config

* fix(cli): fix mud.ts shebang

* refactor(cli): fix minor eslint problems

* chore(cli): add lint to scripts

* feat(cli): use moduleResolution nodenext when testing tsc

* fix(create-mud): add missing peerDependency

* feat(cli): remove mud create, deprecated in #424

* fix: resolve indirect conflicts

* refactor(cli): add separate test:next to avoid test failures in CI

* fix(store): use released cli for gas-report

* test: update gas report

---------

Co-authored-by: dk1a <dk1a@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants