-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): deprecate create command #424
Conversation
Didn't realize it was essentially deprecated. I can remove it in #417 then, it'll fit in with the other removals and avoid resolving conflicts with this PR |
Yep, just the I would kinda prefer to keep this deprecation separate from the big refactor, just to minimize blast radius/what's changing. Coupling a big refactor and a deprecation is a little scary to me (in case one breaks). Is that okay? |
Of course, I meant that your PR goes into main soonish, and my refactor with its removals goes into v2 (#417 isn't needed in v1 as its main purpose is to pave the way for autogen) |
Ohh that sounds perfect. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
* feat(cli): refactor to esm * feat(services): make services more compatible with esm * build(cli): add clarifications to tsup config * fix(cli): fix mud.ts shebang * refactor(cli): fix minor eslint problems * chore(cli): add lint to scripts * feat(cli): use moduleResolution nodenext when testing tsc * fix(create-mud): add missing peerDependency * feat(cli): remove mud create, deprecated in #424 * fix: resolve indirect conflicts * refactor(cli): add separate test:next to avoid test failures in CI * fix(store): use released cli for gas-report * test: update gas report --------- Co-authored-by: dk1a <dk1a@users.noreply.github.com>
Deprecates
mud create
cli command in favor ofyarn create mud
. This is a "bridge" commit that deprecates the command but still allows it to run (by usingyarn create mud
under the hood). In a future version, we should remove this command all together. Happy to do this sooner if you think that's warranted.Also deprecated+archived the template repos:
https://github.com/latticexyz/mud-template-minimal
https://github.com/latticexyz/mud-template-react